all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Thierry Volpiatto <thierry.volpiatto@gmail.com>
Cc: 8926@debbugs.gnu.org
Subject: bug#8926: 24.0.50; pcomplete regression
Date: Thu, 30 Jun 2011 17:19:46 -0400	[thread overview]
Message-ID: <jwvmxgzm30y.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <87hb77jjr5.fsf@gmail.com> (Thierry Volpiatto's message of "Thu,  30 Jun 2011 19:45:34 +0200")

>>>> Yup.  Because among the various completion cases, the case for "files"
>>>> used to return a list and now returns a function.  Both are valid
>>>> completion tables.  Any caller of pcomplete-completions should expect to
>>>> receive a completion table and not just a list of strings.  It may very
>>>> well receive a list of strings (which is one kind of completion table),
>>>> but it may just as well receive something else.
>>> Yes i saw that, and it's what i didn't understand.
>> 
>> BTW, the reason for the above change was not just to fix a bug when
>> using pcomplete-completions-at-point but also so that partial-completion
>> now works with pcomplete-entries (so you can "cd ~/e/e TAB" to go to
>> ~/etc/emacs).
> Yes, but the downside is now that it is hard to use by external
> libraries outside the context of emacs shell/eshell.

Presumably such code already handles completion tables, so having to
handle a completion table rather than a list of strings shouldn't be
that much of a problem.  Calling `all-completions' shouldn't scare
those authors.


        Stefan





  reply	other threads:[~2011-06-30 21:19 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-24  7:03 bug#8926: 24.0.50; pcomplete regression thierry
2011-06-25 16:43 ` Thierry Volpiatto
2011-06-27  1:18   ` Stefan Monnier
2011-06-27  4:21     ` Thierry Volpiatto
2011-06-30 16:51       ` Stefan Monnier
2011-06-30 16:53       ` Stefan Monnier
2011-06-30 17:45         ` Thierry Volpiatto
2011-06-30 21:19           ` Stefan Monnier [this message]
2011-07-01  4:41             ` Thierry Volpiatto
2011-07-01 14:33               ` Stefan Monnier
2011-07-01 19:30                 ` Thierry Volpiatto
2011-07-01 21:59         ` Thierry Volpiatto
2011-07-04 16:00           ` Stefan Monnier
2011-06-26 13:03 ` Stefan Monnier
2011-06-26 18:17   ` Thierry Volpiatto

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwvmxgzm30y.fsf-monnier+emacs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=8926@debbugs.gnu.org \
    --cc=thierry.volpiatto@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.