From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#10489: 24.0.92; dired-do-copy may create infinite directory hierarchy Date: Fri, 13 Jan 2012 08:27:46 -0500 Message-ID: References: <87mx9su32g.fsf@web.de> <87sjjkfvwt.fsf@gmail.com> <8362ggkquq.fsf@gnu.org> <87pqeoro8p.fsf@gmail.com> <83wr8vki5t.fsf@gnu.org> <8762gfdael.fsf@gmx.de> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1326461321 20108 80.91.229.12 (13 Jan 2012 13:28:41 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Fri, 13 Jan 2012 13:28:41 +0000 (UTC) Cc: Juanma Barranquero , 10489@debbugs.gnu.org, Thierry Volpiatto To: Michael Albinus Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Jan 13 14:28:35 2012 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1RlhBK-0002oE-Qn for geb-bug-gnu-emacs@m.gmane.org; Fri, 13 Jan 2012 14:28:34 +0100 Original-Received: from localhost ([::1]:58885 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RlhBK-0005SF-Ai for geb-bug-gnu-emacs@m.gmane.org; Fri, 13 Jan 2012 08:28:34 -0500 Original-Received: from eggs.gnu.org ([140.186.70.92]:49742) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RlhBC-0005R2-RP for bug-gnu-emacs@gnu.org; Fri, 13 Jan 2012 08:28:32 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RlhBB-0001Op-FC for bug-gnu-emacs@gnu.org; Fri, 13 Jan 2012 08:28:26 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:33104) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RlhBB-0001Ol-Cx for bug-gnu-emacs@gnu.org; Fri, 13 Jan 2012 08:28:25 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1RlhBl-0002dT-QK for bug-gnu-emacs@gnu.org; Fri, 13 Jan 2012 08:29:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 13 Jan 2012 13:29:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 10489 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 10489-submit@debbugs.gnu.org id=B10489.132646131010089 (code B ref 10489); Fri, 13 Jan 2012 13:29:01 +0000 Original-Received: (at 10489) by debbugs.gnu.org; 13 Jan 2012 13:28:30 +0000 Original-Received: from localhost ([127.0.0.1]:56009 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1RlhBF-0002cg-M9 for submit@debbugs.gnu.org; Fri, 13 Jan 2012 08:28:29 -0500 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.183]:65324) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1RlhBB-0002cW-88 for 10489@debbugs.gnu.org; Fri, 13 Jan 2012 08:28:28 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Av4EAMowEE9FxKkV/2dsb2JhbABCqmWCMoEGgXIBAQQBViMFCws0EhQYDSSIDbcTjB0EiDyaYYRS X-IronPort-AV: E=Sophos;i="4.71,504,1320642000"; d="scan'208";a="156580770" Original-Received: from 69-196-169-21.dsl.teksavvy.com (HELO pastel.home) ([69.196.169.21]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 13 Jan 2012 08:27:47 -0500 Original-Received: by pastel.home (Postfix, from userid 20848) id C8FD159460; Fri, 13 Jan 2012 08:27:46 -0500 (EST) In-Reply-To: <8762gfdael.fsf@gmx.de> (Michael Albinus's message of "Fri, 13 Jan 2012 14:01:06 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.92 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:55687 Archived-At: IIUC the problem at hand can be solved by disregarding names and comparing (file-attributes) instead, since we're checking whether two names refer to the exact same (existing) directory. >> As this seems like a common occurrence, how comes that we don't have >> >> (defun file-name-compare (name1 name2 &optional dir) >> "..." >> (let ((n1 (file-truename (expand-file-name name1 dir))) >> (n2 (file-truename (expand-file-name name2 dir)))) >> (when (memq system-type '(ms-dos windows-nt)) >> (setq n1 (downcase n1) >> n2 (downcase n2))) >> (string= n1 n2))) file-name-equal-p would be nice, indeed, as discussed a few months (years?) ago. > I wouldn't check for `system-type', there might be other systems which > do not care filename cases (VMS?). I would let-bind `case-fold-search', > derived from `read-file-name-completion-ignore-case'. read-file-name-completion-ignore-case is a user configuration which only reflects the underlying system's sensitivity by default but the user is free to modify it. I used to set it to t under GNU/Linux, for instance. Stefan