all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@iro.umontreal.ca>
To: martin rudalics <rudalics@gmx.at>
Cc: "Jérémy Compostella" <jeremy.compostella@gmail.com>, emacs-devel@gnu.org
Subject: Re: [PATCH] window.el: Improve mark management
Date: Fri, 20 Jan 2012 11:11:27 -0500	[thread overview]
Message-ID: <jwvmx9imk5w.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <4F1984A2.5060900@gmx.at> (martin rudalics's message of "Fri, 20 Jan 2012 16:13:38 +0100")

>> `push-mark' is wrong if nothing happened between window-state-get and
>> window-state-put.
>> And the mark & mark-active are buffer-local but not window-local.
>> If we window-state-get in a frame which shows the same buffer several
>> times, window-state-put would end up pushing the same mark several times.

> We could refuse pushing the mark when current and old position are the
> same.  But obviously pushing the mark from a non-current buffer is not
> very reasonable either.

> IIRC all I tried was to emulate the behavior for window configurations.
> What would you suggest instead?  Not save the mark in the first place?

I'm not completely sure.  The current code doesn't seem that bad since,
as you say, it basically reproduces the behavior of
window-configurations.

So I'd like to first hear of what are concrete cases where the current
behavior is a problem.


        Stefan



  reply	other threads:[~2012-01-20 16:11 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-19 19:43 [PATCH] window.el: Improve mark management Jérémy Compostella
2012-01-20 10:01 ` martin rudalics
2012-01-20 13:42 ` Stefan Monnier
2012-01-20 15:13   ` martin rudalics
2012-01-20 16:11     ` Stefan Monnier [this message]
2012-01-20 16:52   ` Jérémy Compostella
2012-01-20 18:25     ` Stefan Monnier
2012-01-21 14:36       ` Jérémy Compostella
2012-01-24 20:31         ` Stefan Monnier
2012-01-25 10:32           ` martin rudalics
2012-01-25 13:45             ` Stefan Monnier
2012-01-25 15:01               ` Jérémy Compostella

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwvmx9imk5w.fsf-monnier+emacs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=emacs-devel@gnu.org \
    --cc=jeremy.compostella@gmail.com \
    --cc=rudalics@gmx.at \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.