From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#11348: 24.0.95; TAB-completion in shell-command produces d:\/foo on MS-Windows Date: Mon, 07 May 2012 20:27:36 -0400 Message-ID: References: <83obqeiwb0.fsf@gnu.org> <83mx5n6ceu.fsf@gnu.org> <83fwbf5e8v.fsf@gnu.org> <87ipg8km2r.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1336436892 17211 80.91.229.3 (8 May 2012 00:28:12 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Tue, 8 May 2012 00:28:12 +0000 (UTC) Cc: 11348@debbugs.gnu.org To: Chong Yidong Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue May 08 02:28:11 2012 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1SRYHf-00028Y-6a for geb-bug-gnu-emacs@m.gmane.org; Tue, 08 May 2012 02:28:07 +0200 Original-Received: from localhost ([::1]:60933 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SRYHe-0003Ym-IV for geb-bug-gnu-emacs@m.gmane.org; Mon, 07 May 2012 20:28:06 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:52375) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SRYHZ-0003YS-OU for bug-gnu-emacs@gnu.org; Mon, 07 May 2012 20:28:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SRYHX-0004jG-VX for bug-gnu-emacs@gnu.org; Mon, 07 May 2012 20:28:01 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:39149) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SRYHX-0004jC-SB for bug-gnu-emacs@gnu.org; Mon, 07 May 2012 20:27:59 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1SRYJW-0002Aw-OV for bug-gnu-emacs@gnu.org; Mon, 07 May 2012 20:30:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 08 May 2012 00:30:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 11348 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 11348-submit@debbugs.gnu.org id=B11348.13364369898321 (code B ref 11348); Tue, 08 May 2012 00:30:02 +0000 Original-Received: (at 11348) by debbugs.gnu.org; 8 May 2012 00:29:49 +0000 Original-Received: from localhost ([127.0.0.1]:40183 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SRYJI-0002AA-Sh for submit@debbugs.gnu.org; Mon, 07 May 2012 20:29:49 -0400 Original-Received: from ironport-out.teksavvy.com ([206.248.143.162]:2512) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SRYJH-00029r-0I for 11348@debbugs.gnu.org; Mon, 07 May 2012 20:29:47 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AjEKACxOgk9FxLCA/2dsb2JhbABDtheCDAOBDIEIggkBAQQBViMQCw4mEhQYDSSIHAW2MothhHkEpEWBXYMD X-IronPort-AV: E=Sophos;i="4.75,391,1330923600"; d="scan'208";a="178864655" Original-Received: from 69-196-176-128.dsl.teksavvy.com (HELO pastel.home) ([69.196.176.128]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 07 May 2012 20:27:37 -0400 Original-Received: by pastel.home (Postfix, from userid 20848) id 02AC5596D6; Mon, 7 May 2012 20:27:36 -0400 (EDT) In-Reply-To: <87ipg8km2r.fsf@gnu.org> (Chong Yidong's message of "Tue, 08 May 2012 00:11:40 +0800") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.1.50 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:59850 Archived-At: >> No, it does match "\g" but then the new code: >> >> (push (cond >> ((null pcomplete-arg-quote-list) >> (goto-char (match-beginning 3)) "\\") >> ((= (match-beginning 3) (match-end 3)) "\\") >> (t (match-string 3))) >> arg)) >> >> sees that pcomplete-arg-quote-list is nil, pushes "\\" and moves >> backward 1 char (to right before the "g") so you end up with >> ("gnu" "\\" "d:"). >> >> Can you check to see why this is not happening? > ?? Why should pcomplete-arg-quote-list be nil? In that same change, you > set it to shell-delimiter-argument-list, which is a non-empty list. Duh! I see I committed the wrong version. I've just installed the patch below which should hopefully fix this one for good this time. Stefan === modified file 'lisp/shell.el' --- lisp/shell.el 2012-05-05 04:18:49 +0000 +++ lisp/shell.el 2012-05-08 00:24:43 +0000 @@ -432,7 +432,7 @@ (set (make-local-variable 'pcomplete-parse-arguments-function) #'shell-parse-pcomplete-arguments) (set (make-local-variable 'pcomplete-arg-quote-list) - shell-delimiter-argument-list) + comint-file-name-quote-list) (set (make-local-variable 'pcomplete-termination-string) (cond ((not comint-completion-addsuffix) "") ((stringp comint-completion-addsuffix)