From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#14176: 24.3.50; `bookmark-completing-read': prompt and return value for "" DEFAULT Date: Thu, 11 Apr 2013 10:03:49 -0400 Message-ID: References: <7707C9A29C4748B093E2167A99592511@us.oracle.com> <87txnda9qd.fsf@gmail.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1365689072 3894 80.91.229.3 (11 Apr 2013 14:04:32 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 11 Apr 2013 14:04:32 +0000 (UTC) Cc: 14176@debbugs.gnu.org To: Thierry Volpiatto Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Apr 11 16:04:35 2013 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1UQI78-0002Rn-OH for geb-bug-gnu-emacs@m.gmane.org; Thu, 11 Apr 2013 16:04:34 +0200 Original-Received: from localhost ([::1]:50633 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UQI78-0003O2-C3 for geb-bug-gnu-emacs@m.gmane.org; Thu, 11 Apr 2013 10:04:34 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:52918) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UQI71-0003Nw-Ud for bug-gnu-emacs@gnu.org; Thu, 11 Apr 2013 10:04:32 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UQI70-0007Ib-5E for bug-gnu-emacs@gnu.org; Thu, 11 Apr 2013 10:04:27 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:41603) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UQI70-0007IT-16 for bug-gnu-emacs@gnu.org; Thu, 11 Apr 2013 10:04:26 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1UQIAf-0000CR-SU for bug-gnu-emacs@gnu.org; Thu, 11 Apr 2013 10:08:14 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 11 Apr 2013 14:08:12 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 14176 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 14176-submit@debbugs.gnu.org id=B14176.1365689283596 (code B ref 14176); Thu, 11 Apr 2013 14:08:12 +0000 Original-Received: (at 14176) by debbugs.gnu.org; 11 Apr 2013 14:08:03 +0000 Original-Received: from localhost ([127.0.0.1]:45712 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UQIAP-00008l-Mm for submit@debbugs.gnu.org; Thu, 11 Apr 2013 10:08:01 -0400 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.182]:31543) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UQIAG-00006j-D1 for 14176@debbugs.gnu.org; Thu, 11 Apr 2013 10:07:51 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Av8EABK/CFFFxIEd/2dsb2JhbABEuzWDWRdzgh4BAQQBViMFCws0EhQYDSSIHgbBLZEKA6R6gV6DEw X-IPAS-Result: Av8EABK/CFFFxIEd/2dsb2JhbABEuzWDWRdzgh4BAQQBViMFCws0EhQYDSSIHgbBLZEKA6R6gV6DEw X-IronPort-AV: E=Sophos;i="4.84,565,1355115600"; d="scan'208";a="7164011" Original-Received: from 69-196-129-29.dsl.teksavvy.com (HELO pastel.home) ([69.196.129.29]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 11 Apr 2013 10:03:54 -0400 Original-Received: by pastel.home (Postfix, from userid 20848) id 769D467984; Thu, 11 Apr 2013 10:03:49 -0400 (EDT) In-Reply-To: <87txnda9qd.fsf@gmail.com> (Thierry Volpiatto's message of "Thu, 11 Apr 2013 07:59:22 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:73336 Archived-At: > Isn't there a bad usage of `completing-read' here, IMO the > DEFAULT arg of `completing-read' should be used instead of: > ,---- > | (if (string-equal "" str) default str) > `---- Sounds like a left-over from previous code, indeed. > Also why is 'default' let-bounded ? > Here a patch: Feel free to install it (assuming you've confirmed it works, that is ;-) Stefan