From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#15501: 24.3; usage of read-passwd within format-alist Date: Fri, 04 Oct 2013 14:26:57 -0400 Message-ID: References: <524ABE91.7070301@gmx.de> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1380913544 14017 80.91.229.3 (4 Oct 2013 19:05:44 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 4 Oct 2013 19:05:44 +0000 (UTC) Cc: 15501@debbugs.gnu.org To: mhoram@gmx.de Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Oct 04 21:05:45 2013 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1VSAh7-00047z-6E for geb-bug-gnu-emacs@m.gmane.org; Fri, 04 Oct 2013 21:05:45 +0200 Original-Received: from localhost ([::1]:49233 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VSAh6-00086v-5j for geb-bug-gnu-emacs@m.gmane.org; Fri, 04 Oct 2013 15:05:44 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:49025) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VSAgb-0007aS-Lt for bug-gnu-emacs@gnu.org; Fri, 04 Oct 2013 15:05:25 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VSAgU-0001hv-4y for bug-gnu-emacs@gnu.org; Fri, 04 Oct 2013 15:05:13 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:46158) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VSAgU-0001ho-2U for bug-gnu-emacs@gnu.org; Fri, 04 Oct 2013 15:05:06 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1VSAgT-00014z-Mu for bug-gnu-emacs@gnu.org; Fri, 04 Oct 2013 15:05:05 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 04 Oct 2013 19:05:05 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 15501 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 15501-submit@debbugs.gnu.org id=B15501.13809134734027 (code B ref 15501); Fri, 04 Oct 2013 19:05:05 +0000 Original-Received: (at 15501) by debbugs.gnu.org; 4 Oct 2013 19:04:33 +0000 Original-Received: from localhost ([127.0.0.1]:54435 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VSAfw-00012r-0U for submit@debbugs.gnu.org; Fri, 04 Oct 2013 15:04:32 -0400 Original-Received: from pruche.dit.umontreal.ca ([132.204.246.22]:37060) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VSAft-00012R-C8 for 15501@debbugs.gnu.org; Fri, 04 Oct 2013 15:04:29 -0400 Original-Received: from faina.iro.umontreal.ca (lechon.iro.umontreal.ca [132.204.27.242]) by pruche.dit.umontreal.ca (8.14.1/8.14.1) with ESMTP id r94J4SWC006960; Fri, 4 Oct 2013 15:04:28 -0400 Original-Received: by faina.iro.umontreal.ca (Postfix, from userid 20848) id CDC28B4377; Fri, 4 Oct 2013 14:26:57 -0400 (EDT) In-Reply-To: <524ABE91.7070301@gmx.de> (mhoram@gmx.de's message of "Tue, 01 Oct 2013 14:22:41 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 1 Rules triggered RV4721=0 X-NAI-Spam-Version: 2.3.0.9362 : core <4721> : inlines <126> : streams <1050162> : uri <1555789> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:78928 Archived-At: > read-password does not hide password characters when used within > format-alist during loading of a file. Indeed, read-passwd now relies on after-change-functions to hide the password characters, but format-insert-file binds inhibit-modification-hooks before calling the function found in format-alist. I installed a patch (see below) which should fix this issue, but I'm curious: what do you use format-alist for that triggered this problem? Stefan --- lisp/subr.el 2013-10-03 04:41:23 +0000 +++ lisp/subr.el 2013-10-04 18:20:33 +0000 @@ -2104,6 +2104,7 @@ (setq-local buffer-undo-list t) (setq-local select-active-regions nil) (use-local-map read-passwd-map) + (setq-local inhibit-modification-hooks nil) ;bug#15501. (add-hook 'after-change-functions hide-chars-fun nil 'local)) (unwind-protect (let ((enable-recursive-minibuffers t))