all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@IRO.UMontreal.CA>
To: mhoram@gmx.de
Cc: 15501@debbugs.gnu.org
Subject: bug#15501: 24.3; usage of read-passwd within format-alist
Date: Fri, 04 Oct 2013 14:26:57 -0400	[thread overview]
Message-ID: <jwvmwmosyee.fsf-monnier+emacsbugs@gnu.org> (raw)
In-Reply-To: <524ABE91.7070301@gmx.de> (mhoram@gmx.de's message of "Tue, 01 Oct 2013 14:22:41 +0200")

> read-password does not hide password characters when used within
> format-alist during loading of a file.

Indeed, read-passwd now relies on after-change-functions to hide the
password characters, but format-insert-file binds
inhibit-modification-hooks before calling the function found in
format-alist.

I installed a patch (see below) which should fix this issue, but I'm
curious: what do you use format-alist for that triggered this problem?


        Stefan


--- lisp/subr.el	2013-10-03 04:41:23 +0000
+++ lisp/subr.el	2013-10-04 18:20:33 +0000
@@ -2104,6 +2104,7 @@
             (setq-local buffer-undo-list t)
             (setq-local select-active-regions nil)
             (use-local-map read-passwd-map)
+            (setq-local inhibit-modification-hooks nil) ;bug#15501.
             (add-hook 'after-change-functions hide-chars-fun nil 'local))
         (unwind-protect
             (let ((enable-recursive-minibuffers t))





  reply	other threads:[~2013-10-04 18:26 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-01 12:22 bug#15501: 24.3; usage of read-passwd within format-alist mhoram
2013-10-04 18:26 ` Stefan Monnier [this message]
2013-10-07 19:34   ` mhoram

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwvmwmosyee.fsf-monnier+emacsbugs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=15501@debbugs.gnu.org \
    --cc=mhoram@gmx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.