From: Stefan Monnier <monnier@iro.umontreal.ca>
To: yary <not.com@gmail.com>
Cc: 15577 <15577@debbugs.gnu.org>
Subject: bug#15577: 24.3; dir-local variables not applied when switching major-mode
Date: Fri, 18 Oct 2013 21:18:39 -0400 [thread overview]
Message-ID: <jwvmwm6dq96.fsf-monnier+emacsbugs@gnu.org> (raw)
In-Reply-To: <CAG2CFAY1k+kgqD_kdwp5GchofY+1ZZe=U8AnxtgtXi4JViGP5g@mail.gmail.com> (yary's message of "Fri, 18 Oct 2013 11:43:54 -0400")
> For sub-issue #1 "dir-locals not being applied in the new mode,"
> divide the responsibility for setting file-locals and dir-locals
> between `normal-mode find-file=t' and `define-derived-mode'. Just have
> `define-derived-mode' call
> `(hack-dir-local-variables)(hack-local-variables-apply)' unless it is
> being called as a result of `normal-mode t'. There's no change needed
> for the normal-mode function or anything it calls, except perhaps
> setting something that the define-derived-mode macro can check.
Yes, as mentioned earlier, a possible fix is to move the file-local and
dir-local setup code from normal-mode to after-change-major-mode-hook.
> a. Get all of that mode's customizable buffer-locals.
Not sure what that is.
> Ideally the minor-mode, or emacs core, would provide a function for
> that purpose.
It's probably not possible (not reliably at least) with the way minor
modes are defined currently. Tho depending on what you mean it might be
a non-issue.
> b. Mark those variables as permanent-local
There's no such thing, currently (we instead have to use a hack with
change-major-mode-hook, along the lines of what you did).
For minor-modes, what we could do is to check which buffer-local
minor-modes are enabled, and to "simply" re-enable them in
after-change-major-mode-hook.
But there are some issues:
- we have to find out which buffer-local minor-modes are enabled, which
presumes we have some kind of list of minor-modes. We can probably
use minor-mode-list for that, tho.
- some minor modes are mode-specific; e.g. it doesn't make much sense to
preserve reftex-mode when switching from latex-mode to haskell-mode.
Stefan
next prev parent reply other threads:[~2013-10-19 1:18 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-09 20:14 bug#15577: 24.3; dir-local variables not applied when switching major-mode yary
2013-10-09 21:42 ` Glenn Morris
2013-10-10 18:34 ` yary
2013-10-10 21:27 ` Glenn Morris
2013-10-10 21:52 ` Stefan Monnier
2013-10-10 23:12 ` yary
2013-10-14 18:41 ` yary
2013-10-16 14:26 ` yary
2013-10-18 15:43 ` yary
2013-10-19 1:18 ` Stefan Monnier [this message]
2013-10-19 19:08 ` yary
2013-10-19 21:55 ` Stefan Monnier
2013-10-20 13:00 ` yary
2013-10-20 13:38 ` Phil Sainty
2013-10-21 13:11 ` Stefan Monnier
2013-10-21 13:23 ` yary
2013-10-21 14:23 ` Stefan Monnier
2013-10-21 21:58 ` Phil Sainty
2013-10-18 16:29 ` Phil Sainty
[not found] ` <mailman.3789.1381430919.10748.bug-gnu-emacs@gnu.org>
2016-05-05 11:26 ` Alan Mackenzie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvmwm6dq96.fsf-monnier+emacsbugs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=15577@debbugs.gnu.org \
--cc=not.com@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.