From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] emacs-24 r117079: * minibuf.c (read_minibuf): Avoid C99ism in previous patch. Date: Wed, 07 May 2014 20:41:54 -0400 Message-ID: References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1399509744 5541 80.91.229.3 (8 May 2014 00:42:24 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 8 May 2014 00:42:24 +0000 (UTC) Cc: emacs-devel@gnu.org To: Paul Eggert Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu May 08 02:42:17 2014 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1WiCPf-0001hi-AJ for ged-emacs-devel@m.gmane.org; Thu, 08 May 2014 02:42:15 +0200 Original-Received: from localhost ([::1]:44154 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WiCPc-00075I-DD for ged-emacs-devel@m.gmane.org; Wed, 07 May 2014 20:42:12 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:35808) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WiCPT-00074M-2g for emacs-devel@gnu.org; Wed, 07 May 2014 20:42:10 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WiCPL-0004lQ-Ik for emacs-devel@gnu.org; Wed, 07 May 2014 20:42:03 -0400 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.181]:12685) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WiCPL-0004lE-Dh for emacs-devel@gnu.org; Wed, 07 May 2014 20:41:55 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: ArYGAIDvNVO4rwut/2dsb2JhbABZDoJ4g0q9L4MOgRcXdIIlAQEBAQIBViMFCws0EhQYDSSIBAjSGReOegeEOASjKoVvgWqBcX9cIQ X-IPAS-Result: ArYGAIDvNVO4rwut/2dsb2JhbABZDoJ4g0q9L4MOgRcXdIIlAQEBAQIBViMFCws0EhQYDSSIBAjSGReOegeEOASjKoVvgWqBcX9cIQ X-IronPort-AV: E=Sophos;i="4.97,753,1389762000"; d="scan'208";a="61806194" Original-Received: from 184-175-11-173.dsl.teksavvy.com (HELO pastel.home) ([184.175.11.173]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 07 May 2014 20:41:54 -0400 Original-Received: by pastel.home (Postfix, from userid 20848) id 1D7116054B; Wed, 7 May 2014 20:41:54 -0400 (EDT) In-Reply-To: (Paul Eggert's message of "Wed, 07 May 2014 19:28:12 +0000") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4.50 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 206.248.154.181 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:171772 Archived-At: > + Lisp_Object histval; > Lisp_Object empty_minibuf; > Lisp_Object dummy, frame; > @@ -536,11 +537,12 @@ > Vminibuffer_completing_file_name = Qlambda; > /* If variable is unbound, make it nil. */ > - Lisp_Object histval = find_symbol_value (Vminibuffer_history_variable); > - if (EQ (histval, Qunbound)) { > - Fset (Vminibuffer_history_variable, Qnil); > - histval = Qnil; > - } > + histval = find_symbol_value (Vminibuffer_history_variable); Please keep the initialization together with the declaration whenever possible (such as here). Stefan