From: Stefan Monnier <monnier@IRO.UMontreal.CA>
To: Leo Liu <sdl.web@gmail.com>
Cc: 18341@debbugs.gnu.org
Subject: bug#18341: 24.4.50; [patch] control where hook is added minibuffer-with-setup-hook
Date: Thu, 28 Aug 2014 22:03:47 -0400 [thread overview]
Message-ID: <jwvmwaohx3m.fsf-monnier+emacsbugs@gnu.org> (raw)
In-Reply-To: <m31ts03xnb.fsf@gmail.com> (Leo Liu's message of "Fri, 29 Aug 2014 09:14:16 +0800")
> + (when (eq (car-safe fun) :append)
> + (setq append t)
Please make it '(t) so you can use ,@append and get marginally cleaner
macroexpanded code when :append is not used.
> + (pop fun))
I think this implements (:append . FUN) rather than (:append FUN).
Other than that, feel free to install into trunk.
Stefan
next prev parent reply other threads:[~2014-08-29 2:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-28 4:54 bug#18341: 24.4.50; [patch] control where hook is added minibuffer-with-setup-hook Leo Liu
2014-08-28 13:12 ` Stefan Monnier
2014-08-29 1:14 ` Leo Liu
2014-08-29 2:03 ` Stefan Monnier [this message]
2014-08-29 2:51 ` Leo Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvmwaohx3m.fsf-monnier+emacsbugs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=18341@debbugs.gnu.org \
--cc=sdl.web@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.