From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#18413: Inline part displayed in the middle of its button Date: Fri, 31 Oct 2014 10:26:33 -0400 Message-ID: References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1414767768 14061 80.91.229.3 (31 Oct 2014 15:02:48 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 31 Oct 2014 15:02:48 +0000 (UTC) To: 18413@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Oct 31 16:02:40 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1XkDip-0004ii-9O for geb-bug-gnu-emacs@m.gmane.org; Fri, 31 Oct 2014 16:02:39 +0100 Original-Received: from localhost ([::1]:51522 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XkDio-0006Gm-T6 for geb-bug-gnu-emacs@m.gmane.org; Fri, 31 Oct 2014 11:02:38 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:34688) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XkDgE-00013u-Q1 for bug-gnu-emacs@gnu.org; Fri, 31 Oct 2014 11:00:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XkDBL-0007HZ-76 for bug-gnu-emacs@gnu.org; Fri, 31 Oct 2014 10:28:08 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:49131) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XkDBL-0007HL-3l for bug-gnu-emacs@gnu.org; Fri, 31 Oct 2014 10:28:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1XkDBK-0001kb-BJ; Fri, 31 Oct 2014 10:28:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org, bugs@gnus.org Resent-Date: Fri, 31 Oct 2014 14:28:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 18413 X-GNU-PR-Package: emacs,gnus X-GNU-PR-Keywords: Original-Received: via spool by 18413-submit@debbugs.gnu.org id=B18413.14147656376671 (code B ref 18413); Fri, 31 Oct 2014 14:28:02 +0000 Original-Received: (at 18413) by debbugs.gnu.org; 31 Oct 2014 14:27:17 +0000 Original-Received: from localhost ([127.0.0.1]:41228 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XkDAa-0001jX-S7 for submit@debbugs.gnu.org; Fri, 31 Oct 2014 10:27:17 -0400 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.181]:36451) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XkDAX-0001jH-0m for 18413@debbugs.gnu.org; Fri, 31 Oct 2014 10:27:14 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Ag4NAOatTlRFpY87/2dsb2JhbABcgw6BLII2hn7LUwQCAoEcFwEBfIQDAQEDAVYoCws0EhQNCw03iCwDCQnFLQ2GOAEBCAIgjk6CQRaENQWbUJFihG6Bb4QUIS+CSwEBAQ X-IPAS-Result: Ag4NAOatTlRFpY87/2dsb2JhbABcgw6BLII2hn7LUwQCAoEcFwEBfIQDAQEDAVYoCws0EhQNCw03iCwDCQnFLQ2GOAEBCAIgjk6CQRaENQWbUJFihG6Bb4QUIS+CSwEBAQ X-IronPort-AV: E=Sophos;i="5.04,797,1406606400"; d="scan'208";a="95666448" Original-Received: from 69-165-143-59.dsl.teksavvy.com (HELO pastel.home) ([69.165.143.59]) by ironport2-out.teksavvy.com with ESMTP/TLS/DHE-RSA-AES256-SHA; 31 Oct 2014 10:27:05 -0400 Original-Received: by pastel.home (Postfix, from userid 20848) id C262A62BA; Fri, 31 Oct 2014 10:26:33 -0400 (EDT) In-Reply-To: (Stefan Monnier's message of "Fri, 05 Sep 2014 14:09:16 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:95291 Ping? Stefan >>>>> "Stefan" == Stefan Monnier writes: > Package: emacs,gnus > Version: 24.4.50 > Here's what I do: > - start Gnus > - visit a message with an Elisp attachment (in my case I tested with > a message from Tom on emacs-devel with subject > "Re: History for query replace pairs" and with an attachment of type > "application/emacs-lisp"). > - place cursor in the middle of the attachment's button (using keyboard > commands). > - press E > Result: the attachment is shown inline, but right in the middle of the > button. IOW I get "[4. applicati" (from the button's text before > point), followed by the attachment's content, followed by > "on/emacs-lisp; hist.el]". The whole is in bold for me, because the > button is an overlay with `bold' face, so the face ends up covering the > inline attachment as well. > It seems to be the result of the hunk below. > Stefan > revno: 117041 > committer: Katsumi Yamaoka > branch nick: trunk > timestamp: Fri 2014-05-02 09:44:34 +0000 > message: > Gnus: Make gnus-mime-inline-part and gnus-mime-inline-part work similarly > * gnus-art.el (gnus-mime-inline-part): Redisplay a button so as to show > the displaying state of a part. > (gnus-mime-inline-part): Don't insert a newline in the beginning of > a part like gnus-mime-inline-part doesn't; work for XEmacs. > * mm-decode.el (mm-display-part): Don't insert a newline in the top. > (mm-shr): Make undisplayer unbreakable. > * mm-view.el (mm-inline-image-emacs, mm-inline-image-xemacs): Don't > insert excessive newline. > (mm-inline-text-html-render-with-w3m, mm-inline-text) > (mm-insert-inline): Make undisplayer unbreakable. > --- lisp/gnus/mm-decode.el 2014-03-23 23:13:36 +0000 > +++ lisp/gnus/mm-decode.el 2014-05-02 09:44:34 +0000 > @@ -821,7 +821,6 @@ > 'inline) > ((and (mm-inlinable-p ehandle) > (mm-inlined-p ehandle)) > - (forward-line 1) > (mm-display-inline handle) > 'inline) > ((or method