all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@iro.umontreal.ca>
To: 18413@debbugs.gnu.org
Subject: bug#18413: Inline part displayed in the middle of its button
Date: Fri, 31 Oct 2014 10:26:33 -0400	[thread overview]
Message-ID: <jwvmw8cz57d.fsf-monnier+emacsbugs@gnu.org> (raw)
In-Reply-To: <jwvwq9irlbn.fsf@iro.umontreal.ca> (Stefan Monnier's message of "Fri, 05 Sep 2014 14:09:16 -0400")

Ping?


        Stefan


>>>>> "Stefan" == Stefan Monnier <monnier@iro.umontreal.ca> writes:

> Package: emacs,gnus
> Version: 24.4.50


> Here's what I do:
> - start Gnus
> - visit a message with an Elisp attachment (in my case I tested with
>   a message from Tom <adatgyujto@gmail.com> on emacs-devel with subject
>   "Re: History for query replace pairs" and with an attachment of type
>   "application/emacs-lisp").
> - place cursor in the middle of the attachment's button (using keyboard
> commands).
> - press E

> Result: the attachment is shown inline, but right in the middle of the
> button.  IOW I get "[4. applicati" (from the button's text before
> point), followed by the attachment's content, followed by
> "on/emacs-lisp; hist.el]".  The whole is in bold for me, because the
> button is an overlay with `bold' face, so the face ends up covering the
> inline attachment as well.

> It seems to be the result of the hunk below.


>         Stefan


> revno: 117041
> committer: Katsumi Yamaoka <yamaoka@jpl.org>
> branch nick: trunk
> timestamp: Fri 2014-05-02 09:44:34 +0000
> message:
>   Gnus: Make gnus-mime-inline-part and gnus-mime-inline-part work similarly
  
>   * gnus-art.el (gnus-mime-inline-part): Redisplay a button so as to show
>   the displaying state of a part.
>   (gnus-mime-inline-part): Don't insert a newline in the beginning of
>   a part like gnus-mime-inline-part doesn't; work for XEmacs.
  
>   * mm-decode.el (mm-display-part): Don't insert a newline in the top.
>   (mm-shr): Make undisplayer unbreakable.
  
>   * mm-view.el (mm-inline-image-emacs, mm-inline-image-xemacs): Don't
>   insert excessive newline.
>   (mm-inline-text-html-render-with-w3m, mm-inline-text)
>   (mm-insert-inline): Make undisplayer unbreakable.


> --- lisp/gnus/mm-decode.el	2014-03-23 23:13:36 +0000
> +++ lisp/gnus/mm-decode.el	2014-05-02 09:44:34 +0000
> @@ -821,7 +821,6 @@
>  	  'inline)
>  	 ((and (mm-inlinable-p ehandle)
>  	       (mm-inlined-p ehandle))
> -	  (forward-line 1)
>  	  (mm-display-inline handle)
>  	  'inline)
>  	 ((or method








  reply	other threads:[~2014-10-31 14:26 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-05 18:09 bug#18413: Inline part displayed in the middle of its button Stefan Monnier
2014-10-31 14:26 ` Stefan Monnier [this message]
2015-02-14  4:31 ` Stefan Monnier
2015-02-14  5:03 ` Lars Ingebrigtsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwvmw8cz57d.fsf-monnier+emacsbugs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=18413@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.