* bug#19325: file-tree-walk needs to be replaced/removed
@ 2014-12-09 5:24 Glenn Morris
2014-12-09 5:40 ` Leo Liu
2014-12-09 6:23 ` Lars Magne Ingebrigtsen
0 siblings, 2 replies; 10+ messages in thread
From: Glenn Morris @ 2014-12-09 5:24 UTC (permalink / raw)
To: 19325
Package: emacs
Severity: important
Version: 25.0.50
Filing a bug so that this does not get overlooked.
file-tree-walk needs to be removed/replaced.
Ref: http://lists.gnu.org/archive/html/emacs-devel/2014-12/msg00306.html
^ permalink raw reply [flat|nested] 10+ messages in thread
* bug#19325: file-tree-walk needs to be replaced/removed
2014-12-09 5:24 bug#19325: file-tree-walk needs to be replaced/removed Glenn Morris
@ 2014-12-09 5:40 ` Leo Liu
2014-12-09 5:47 ` Lars Magne Ingebrigtsen
2014-12-09 6:23 ` Lars Magne Ingebrigtsen
1 sibling, 1 reply; 10+ messages in thread
From: Leo Liu @ 2014-12-09 5:40 UTC (permalink / raw)
To: Glenn Morris; +Cc: 19325
On 2014-12-09 00:24 -0500, Glenn Morris wrote:
> Filing a bug so that this does not get overlooked.
> file-tree-walk needs to be removed/replaced.
> Ref: http://lists.gnu.org/archive/html/emacs-devel/2014-12/msg00306.html
Personally I think a better option is to allow directory-files to take a
function as its MATCH argument. Then the tree walk is only a step away.
Leo
^ permalink raw reply [flat|nested] 10+ messages in thread
* bug#19325: file-tree-walk needs to be replaced/removed
2014-12-09 5:40 ` Leo Liu
@ 2014-12-09 5:47 ` Lars Magne Ingebrigtsen
0 siblings, 0 replies; 10+ messages in thread
From: Lars Magne Ingebrigtsen @ 2014-12-09 5:47 UTC (permalink / raw)
To: Leo Liu; +Cc: 19325
Leo Liu <sdl.web@gmail.com> writes:
> Personally I think a better option is to allow directory-files to take a
> function as its MATCH argument. Then the tree walk is only a step away.
directory-files doesn't work recursively.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
^ permalink raw reply [flat|nested] 10+ messages in thread
* bug#19325: file-tree-walk needs to be replaced/removed
2014-12-09 5:24 bug#19325: file-tree-walk needs to be replaced/removed Glenn Morris
2014-12-09 5:40 ` Leo Liu
@ 2014-12-09 6:23 ` Lars Magne Ingebrigtsen
2014-12-09 6:38 ` Glenn Morris
2014-12-10 19:55 ` Stefan Monnier
1 sibling, 2 replies; 10+ messages in thread
From: Lars Magne Ingebrigtsen @ 2014-12-09 6:23 UTC (permalink / raw)
To: Glenn Morris; +Cc: 19325
Glenn Morris <rgm@gnu.org> writes:
> Filing a bug so that this does not get overlooked.
> file-tree-walk needs to be removed/replaced.
> Ref: http://lists.gnu.org/archive/html/emacs-devel/2014-12/msg00306.html
I've now committed the more generally useful
`directory-files-recursively', which has a saner interface.
`file-tree-walk' can be implemented as
(mapcar 'function (directory-files-recursively ...)) if you want, but it
seems kinda superfluous.
`directory-files-recursively' also returns full names instead of the
directory/leaf name nonsense.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
^ permalink raw reply [flat|nested] 10+ messages in thread
* bug#19325: file-tree-walk needs to be replaced/removed
2014-12-09 6:23 ` Lars Magne Ingebrigtsen
@ 2014-12-09 6:38 ` Glenn Morris
2014-12-09 6:44 ` Lars Magne Ingebrigtsen
2014-12-10 19:55 ` Stefan Monnier
1 sibling, 1 reply; 10+ messages in thread
From: Glenn Morris @ 2014-12-09 6:38 UTC (permalink / raw)
To: Lars Magne Ingebrigtsen; +Cc: 19325
Lars Magne Ingebrigtsen wrote:
> `file-tree-walk' can be implemented as
>
> (mapcar 'function (directory-files-recursively ...)) if you want, but it
> seems kinda superfluous.
Oh, nothing actually uses f-t-w?
Then if no-one objects feel free to nuke it, I think. (And the NEWS and doc.)
Thanks!
^ permalink raw reply [flat|nested] 10+ messages in thread
* bug#19325: file-tree-walk needs to be replaced/removed
2014-12-09 6:38 ` Glenn Morris
@ 2014-12-09 6:44 ` Lars Magne Ingebrigtsen
2014-12-09 6:52 ` Lars Magne Ingebrigtsen
0 siblings, 1 reply; 10+ messages in thread
From: Lars Magne Ingebrigtsen @ 2014-12-09 6:44 UTC (permalink / raw)
To: Glenn Morris; +Cc: 19325
Glenn Morris <rgm@gnu.org> writes:
> Lars Magne Ingebrigtsen wrote:
>
>> `file-tree-walk' can be implemented as
>>
>> (mapcar 'function (directory-files-recursively ...)) if you want, but it
>> seems kinda superfluous.
>
> Oh, nothing actually uses f-t-w?
I haven't actually looked, but I mean that what it does is so trivial
that it's not worth having as a separate function.
People should just mapc over `directory-files-recursively'.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
^ permalink raw reply [flat|nested] 10+ messages in thread
* bug#19325: file-tree-walk needs to be replaced/removed
2014-12-09 6:44 ` Lars Magne Ingebrigtsen
@ 2014-12-09 6:52 ` Lars Magne Ingebrigtsen
0 siblings, 0 replies; 10+ messages in thread
From: Lars Magne Ingebrigtsen @ 2014-12-09 6:52 UTC (permalink / raw)
To: Glenn Morris; +Cc: 19325
Lars Magne Ingebrigtsen <larsi@gnus.org> writes:
> I haven't actually looked, but I mean that what it does is so trivial
> that it's not worth having as a separate function.
It's not used, and there's already a `vc-file-tree-walk' that does a
similar thing, but with a less moronic interface. Only over vc-covered
files, though.
I say nuke `file-tree-walk'.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
^ permalink raw reply [flat|nested] 10+ messages in thread
* bug#19325: file-tree-walk needs to be replaced/removed
2014-12-09 6:23 ` Lars Magne Ingebrigtsen
2014-12-09 6:38 ` Glenn Morris
@ 2014-12-10 19:55 ` Stefan Monnier
2015-01-02 19:32 ` Glenn Morris
1 sibling, 1 reply; 10+ messages in thread
From: Stefan Monnier @ 2014-12-10 19:55 UTC (permalink / raw)
To: Lars Magne Ingebrigtsen; +Cc: 19325
> `directory-files-recursively' also returns full names instead of the
> directory/leaf name nonsense.
I'm not so sure it's non-sense. I think both options have their
respective advantages/disadvantages.
Stefan
^ permalink raw reply [flat|nested] 10+ messages in thread
* bug#19325: file-tree-walk needs to be replaced/removed
2014-12-10 19:55 ` Stefan Monnier
@ 2015-01-02 19:32 ` Glenn Morris
2015-01-03 3:22 ` Stefan Monnier
0 siblings, 1 reply; 10+ messages in thread
From: Glenn Morris @ 2015-01-02 19:32 UTC (permalink / raw)
To: 19325
Several weeks have passed.
Since the code is unassigned and unused, the solution seems obvious to me.
^ permalink raw reply [flat|nested] 10+ messages in thread
* bug#19325: file-tree-walk needs to be replaced/removed
2015-01-02 19:32 ` Glenn Morris
@ 2015-01-03 3:22 ` Stefan Monnier
0 siblings, 0 replies; 10+ messages in thread
From: Stefan Monnier @ 2015-01-03 3:22 UTC (permalink / raw)
To: Glenn Morris; +Cc: 19325
> Several weeks have passed.
> Since the code is unassigned and unused, the solution seems obvious to me.
Yup,
Stefan
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2015-01-03 3:22 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-12-09 5:24 bug#19325: file-tree-walk needs to be replaced/removed Glenn Morris
2014-12-09 5:40 ` Leo Liu
2014-12-09 5:47 ` Lars Magne Ingebrigtsen
2014-12-09 6:23 ` Lars Magne Ingebrigtsen
2014-12-09 6:38 ` Glenn Morris
2014-12-09 6:44 ` Lars Magne Ingebrigtsen
2014-12-09 6:52 ` Lars Magne Ingebrigtsen
2014-12-10 19:55 ` Stefan Monnier
2015-01-02 19:32 ` Glenn Morris
2015-01-03 3:22 ` Stefan Monnier
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.