all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@IRO.UMontreal.CA>
To: samer <samer@samertm.com>
Cc: 18950@debbugs.gnu.org, Dmitry Gutov <dgutov@yandex.ru>
Subject: bug#18950: [PATCH] 24.4.51; Wrong type argument: stringp on completing an asterisk in eshell with pcomplete-cycle-completions disabled
Date: Thu, 15 Jan 2015 10:06:39 -0500	[thread overview]
Message-ID: <jwvmw5kw0bs.fsf-monnier+emacsbugs@gnu.org> (raw)
In-Reply-To: <4fd05af1b84870c40eae10fa421aa17c@samertm.com> (samer@samertm.com's message of "Wed, 14 Jan 2015 20:12:48 -0800")

> -	(if (and pcomplete-cycle-completions
> -		 (listp pcomplete-stub) ;??
> +	(if (and (listp pcomplete-stub) ;??

I haven't had time to look more closely at the bug and the code, but
if this indeed works, then it looks like a good change.


        Stefan





  reply	other threads:[~2015-01-15 15:06 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-05  5:27 bug#18950: 24.4.51; Wrong type argument: stringp on completing an asterisk in eshell with pcomplete-cycle-completions disabled Dmitry Gutov
2015-01-15  4:12 ` bug#18950: [PATCH] " samer
2015-01-15 15:06   ` Stefan Monnier [this message]
2015-01-16  2:36     ` Dmitry Gutov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwvmw5kw0bs.fsf-monnier+emacsbugs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=18950@debbugs.gnu.org \
    --cc=dgutov@yandex.ru \
    --cc=samer@samertm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.