* Re: [Emacs-diffs] master 3a8312d: lisp/emacs-lisp/eieio*.el: Rewrite our generics on top of cl-generic
[not found] ` <E1YDfcK-0002aD-Cr@vcs.savannah.gnu.org>
@ 2015-01-21 6:28 ` Dmitry Gutov
2015-01-21 7:56 ` Tassilo Horn
2015-01-21 20:11 ` Stefan Monnier
0 siblings, 2 replies; 4+ messages in thread
From: Dmitry Gutov @ 2015-01-21 6:28 UTC (permalink / raw
To: emacs-devel, Stefan Monnier
On 01/20/2015 10:41 PM, Stefan Monnier wrote:
> +;;;###autoload
> +(defun eieio-defgeneric (method doc-string)
> + "Obsolete work part of an old version of the `defgeneric' macro."
> + (declare (obsolete cl-defgeneric "24.1"))
> + ;; Don't do this over and over.
> + (unless (fboundp 'method)
I don't think it should be quoted. Although it seems to be a bug from
the previous version.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Emacs-diffs] master 3a8312d: lisp/emacs-lisp/eieio*.el: Rewrite our generics on top of cl-generic
2015-01-21 6:28 ` [Emacs-diffs] master 3a8312d: lisp/emacs-lisp/eieio*.el: Rewrite our generics on top of cl-generic Dmitry Gutov
@ 2015-01-21 7:56 ` Tassilo Horn
2015-01-21 14:08 ` Dmitry Gutov
2015-01-21 20:11 ` Stefan Monnier
1 sibling, 1 reply; 4+ messages in thread
From: Tassilo Horn @ 2015-01-21 7:56 UTC (permalink / raw
To: Dmitry Gutov; +Cc: Stefan Monnier, emacs-devel
Dmitry Gutov <dgutov@yandex.ru> writes:
>> +;;;###autoload
>> +(defun eieio-defgeneric (method doc-string)
>> + "Obsolete work part of an old version of the `defgeneric' macro."
>> + (declare (obsolete cl-defgeneric "24.1"))
>> + ;; Don't do this over and over.
>> + (unless (fboundp 'method)
>
> I don't think it should be quoted. Although it seems to be a bug from
> the previous version.
Could that be the source of bug#19645?
Bye,
Tassilo
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Emacs-diffs] master 3a8312d: lisp/emacs-lisp/eieio*.el: Rewrite our generics on top of cl-generic
2015-01-21 7:56 ` Tassilo Horn
@ 2015-01-21 14:08 ` Dmitry Gutov
0 siblings, 0 replies; 4+ messages in thread
From: Dmitry Gutov @ 2015-01-21 14:08 UTC (permalink / raw
To: emacs-devel, Stefan Monnier
On 01/21/2015 09:56 AM, Tassilo Horn wrote:
> Could that be the source of bug#19645?
Probably not. But you should be able to test this easily, just remove
the quote and recompile.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Emacs-diffs] master 3a8312d: lisp/emacs-lisp/eieio*.el: Rewrite our generics on top of cl-generic
2015-01-21 6:28 ` [Emacs-diffs] master 3a8312d: lisp/emacs-lisp/eieio*.el: Rewrite our generics on top of cl-generic Dmitry Gutov
2015-01-21 7:56 ` Tassilo Horn
@ 2015-01-21 20:11 ` Stefan Monnier
1 sibling, 0 replies; 4+ messages in thread
From: Stefan Monnier @ 2015-01-21 20:11 UTC (permalink / raw
To: Dmitry Gutov; +Cc: emacs-devel
> I don't think it should be quoted. Although it seems to be a bug from the
> previous version.
Indeed, thanks for spotting this. I just removed the bogus test.
Stefan
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-01-21 20:11 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20150120204140.9895.15414@vcs.savannah.gnu.org>
[not found] ` <E1YDfcK-0002aD-Cr@vcs.savannah.gnu.org>
2015-01-21 6:28 ` [Emacs-diffs] master 3a8312d: lisp/emacs-lisp/eieio*.el: Rewrite our generics on top of cl-generic Dmitry Gutov
2015-01-21 7:56 ` Tassilo Horn
2015-01-21 14:08 ` Dmitry Gutov
2015-01-21 20:11 ` Stefan Monnier
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.