Re: [elpa] master 2ae5b9c 3/7: swiper.el (swiper-font-lock-ensure): Ignore gnus modes

Re: [elpa] master 2ae5b9c 3/7: swiper.el (swiper-font-lock-ensure): Ignore gnus modes

[Stefan Monnier]

>    "Ensure the entired buffer is highlighted."
>    (unless (or (derived-mode-p 'magit-mode)
>                (memq major-mode '(package-menu-mode
> +                                 gnus-summary-mode
> +                                 gnus-article-mode
> +                                 gnus-group-mode
>                                   emms-playlist-mode erc-mode)))
>      (if (fboundp 'font-lock-ensure)
>          (font-lock-ensure)

I think you'll want to list many more modes here.  Or rather, I think
what you really want to test is whether font-lock is in use on
this buffer.
There are various ways to test it, such as testing the value of
font-lock-fontified or font-lock-mode, or calling font-lock-specified-p,
and there might be others.


        Stefan

Re: [elpa] master 2ae5b9c 3/7: swiper.el (swiper-font-lock-ensure): Ignore gnus modes

[Oleh Krehel]

On Thu, Mar 26, 2015 at 2:43 PM, Stefan Monnier
<monnier@iro.umontreal.ca> wrote:
>>    "Ensure the entired buffer is highlighted."
>>    (unless (or (derived-mode-p 'magit-mode)
>>                (memq major-mode '(package-menu-mode
>> +                                 gnus-summary-mode
>> +                                 gnus-article-mode
>> +                                 gnus-group-mode
>>                                   emms-playlist-mode erc-mode)))
>>      (if (fboundp 'font-lock-ensure)
>>          (font-lock-ensure)
>
> I think you'll want to list many more modes here.  Or rather, I think
> what you really want to test is whether font-lock is in use on
> this buffer.
> There are various ways to test it, such as testing the value of
> font-lock-fontified or font-lock-mode, or calling font-lock-specified-p,
> and there might be others.

But what is the cause of discoloration when I call `font-lock-ensure`?

For instance, in `gnus-group-mode`, `font-lock-mode` is t, but
`font-lock-fontified` is nil, and the color is erased when I call
`font-lock-ensure`.

Oleh

Re: [elpa] master 2ae5b9c 3/7: swiper.el (swiper-font-lock-ensure): Ignore gnus modes

[Tassilo Horn]

Oleh Krehel <ohwoeowho@gmail.com> writes:

> But what is the cause of discoloration when I call `font-lock-ensure`?
>
> For instance, in `gnus-group-mode`, `font-lock-mode` is t, but
> `font-lock-fontified` is nil, and the color is erased when I call
> `font-lock-ensure`.

I think Gnus propertizes the contents using the 'face property whereas
it should actually use the 'font-lock-face property (or disable
font-lock).

Bye,
Tassilo

Re: [elpa] master 2ae5b9c 3/7: swiper.el (swiper-font-lock-ensure): Ignore gnus modes

[Stefan Monnier]

> I think Gnus propertizes the contents using the 'face property whereas
> it should actually use the 'font-lock-face property (or disable
> font-lock).

Indeed, but it's far from the only one, so there's no point chasing
all those modes.


        Stefan