From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#21383: Static revisions in vc-working-revision Date: Mon, 31 Aug 2015 23:55:22 -0400 Message-ID: References: <55E41499.5030501@yandex.ru> <55E5094A.3010108@yandex.ru> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1441079784 4072 80.91.229.3 (1 Sep 2015 03:56:24 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 1 Sep 2015 03:56:24 +0000 (UTC) Cc: 21383@debbugs.gnu.org, Jonathan H To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Sep 01 05:56:12 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ZWcg7-0000dg-C9 for geb-bug-gnu-emacs@m.gmane.org; Tue, 01 Sep 2015 05:56:11 +0200 Original-Received: from localhost ([::1]:44023 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZWcg7-0000It-9P for geb-bug-gnu-emacs@m.gmane.org; Mon, 31 Aug 2015 23:56:11 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:37968) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZWcg3-0000Il-4h for bug-gnu-emacs@gnu.org; Mon, 31 Aug 2015 23:56:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZWcfy-0008KX-6m for bug-gnu-emacs@gnu.org; Mon, 31 Aug 2015 23:56:07 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:52348) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZWcfy-0008KT-3h for bug-gnu-emacs@gnu.org; Mon, 31 Aug 2015 23:56:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1ZWcfx-0003sS-WA for bug-gnu-emacs@gnu.org; Mon, 31 Aug 2015 23:56:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 01 Sep 2015 03:56:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 21383 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 21383-submit@debbugs.gnu.org id=B21383.144107972514854 (code B ref 21383); Tue, 01 Sep 2015 03:56:01 +0000 Original-Received: (at 21383) by debbugs.gnu.org; 1 Sep 2015 03:55:25 +0000 Original-Received: from localhost ([127.0.0.1]:44558 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZWcfM-0003rW-Nj for submit@debbugs.gnu.org; Mon, 31 Aug 2015 23:55:25 -0400 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.181]:50629) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZWcfL-0003rO-2N for 21383@debbugs.gnu.org; Mon, 31 Aug 2015 23:55:23 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: A0AxFgA731xV//rn92hcgxCEAoVVu0CHSwQCAoE8OxIBAQEBAQEBgQpBBYNdAQEEViMQCw4mEhQYDSSIP88jAQEBAQYBAQEBHos6hQUHhC0FtQQjhBQigngBAQE X-IPAS-Result: A0AxFgA731xV//rn92hcgxCEAoVVu0CHSwQCAoE8OxIBAQEBAQEBgQpBBYNdAQEEViMQCw4mEhQYDSSIP88jAQEBAQYBAQEBHos6hQUHhC0FtQQjhBQigngBAQE X-IronPort-AV: E=Sophos;i="5.13,465,1427774400"; d="scan'208";a="162024231" Original-Received: from 104-247-231-250.cpe.teksavvy.com (HELO ceviche.home) ([104.247.231.250]) by ironport2-out.teksavvy.com with ESMTP/TLS/DHE-RSA-AES256-SHA; 31 Aug 2015 23:55:22 -0400 Original-Received: by ceviche.home (Postfix, from userid 20848) id 30BF16615C; Mon, 31 Aug 2015 23:55:22 -0400 (EDT) In-Reply-To: <55E5094A.3010108@yandex.ru> (Dmitry Gutov's message of "Tue, 1 Sep 2015 05:11:22 +0300") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:106034 Archived-At: > -(defun vc-git-working-revision (file) > +(defun vc-git-working-revision (_file) VC was originally designed so as to separate the VC data from the buffers, so the `file' argument was absolutely indispensable (you can't/shouldn't rely on things like the current-buffer's default-directory). I think nowadays the design has been changed enough that indeed the `file' arg can be dispensed with. The rest looks OK to me, Stefan