From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Adding comment features to Python progmode. Date: Mon, 14 Sep 2015 20:59:32 -0400 Message-ID: References: <1442095672-10718-1-git-send-email-alban.gruin@gmail.com> <871te03htd.fsf@gmail.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1442278793 5333 80.91.229.3 (15 Sep 2015 00:59:53 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 15 Sep 2015 00:59:53 +0000 (UTC) Cc: emacs-devel@gnu.org To: Alban Gruin Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Sep 15 02:59:45 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Zbeb0-0001yw-5G for ged-emacs-devel@m.gmane.org; Tue, 15 Sep 2015 02:59:42 +0200 Original-Received: from localhost ([::1]:44344 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zbeaz-0002VZ-Ex for ged-emacs-devel@m.gmane.org; Mon, 14 Sep 2015 20:59:41 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:38792) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zbeaw-0002VE-AM for emacs-devel@gnu.org; Mon, 14 Sep 2015 20:59:38 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zbear-0004lv-BA for emacs-devel@gnu.org; Mon, 14 Sep 2015 20:59:38 -0400 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.181]:51551) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zbear-0004lp-76 for emacs-devel@gnu.org; Mon, 14 Sep 2015 20:59:33 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: A0AsEwA731xV/0jo92hcgxCEAoVVuzcJh0sEAgKBPDkUAQEBAQEBAYEKQQWDXQEBAwFWIwULCzQSFBgNJIg3CM8jAQEBBwIBH4s6hQUHhC0FnxeSFINZI2GBKB2BbiKCeAEBAQ X-IPAS-Result: A0AsEwA731xV/0jo92hcgxCEAoVVuzcJh0sEAgKBPDkUAQEBAQEBAYEKQQWDXQEBAwFWIwULCzQSFBgNJIg3CM8jAQEBBwIBH4s6hQUHhC0FnxeSFINZI2GBKB2BbiKCeAEBAQ X-IronPort-AV: E=Sophos;i="5.13,465,1427774400"; d="scan'208";a="164848906" Original-Received: from 104-247-232-72.cpe.teksavvy.com (HELO ceviche.home) ([104.247.232.72]) by ironport2-out.teksavvy.com with ESMTP/TLS/DHE-RSA-AES256-SHA; 14 Sep 2015 20:59:33 -0400 Original-Received: by ceviche.home (Postfix, from userid 20848) id 68D7E66113; Mon, 14 Sep 2015 20:59:32 -0400 (EDT) In-Reply-To: <871te03htd.fsf@gmail.com> (Alban Gruin's message of "Mon, 14 Sep 2015 21:46:22 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 206.248.154.181 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:189959 Archived-At: > comment-region comments only a part of a line (where the mark is, which is > useless in Python since you just have to put a hash instead invoking a > command), where python-comment-region comments the entire line. Python is not special in this regard. Whether that's useless or not depends on your habits. It's easy to get your behavior on top of the existing function, so there's no need to write all that new code. Stefan