From: Stefan Monnier <monnier@IRO.UMontreal.CA>
To: Daniel Colascione <dancol@dancol.org>
Cc: Eli Zaretskii <eliz@gnu.org>, emacs-devel@gnu.org
Subject: VC's modeline (was: [Emacs-diffs] master de76a16: Performance improvements for vc-hg)
Date: Mon, 08 Feb 2016 16:39:26 -0500 [thread overview]
Message-ID: <jwvmvragaav.fsf-monnier+emacsdiffs@gnu.org> (raw)
In-Reply-To: <56B8FA6D.9070105@dancol.org> (Daniel Colascione's message of "Mon, 8 Feb 2016 12:28:29 -0800")
> vc has been in place for decades, and is one of the things that makes
> programming on Emacs pleasant. I'm not in favor of just removing the
> feature because there are a few unfixed bugs. There is nothing
> fundamentally wrong with the model.
Agreed.
What I think is wrong the level of detail expected in the status line.
E.g. I think it'd be fine for VC to just display "Bzr" (or "Hg", or
"Git", or what have you) instead. I think it'd even be fine to do that
without checking whether the file is really under that VCS's control or
not (i.e. without checking whether the file is ignored). IOW, a file
opened in a directory with a ".git" somewhere in the parents could just
say "Git", without any other check.
> There is no reason that vc integration can't work well and be on by
> default.
Having to call a "git" process twice per find-file-noselect is a high
price for a very small benefit.
> It was working before my change; now it works better.
Yes, I'm really not arguing against your change.
> A reasonable performance improvement should not be an occasion for
> discussing the removal of a feature made faster.
Sorry. It just reminded me of this problem that's been around for a while.
Stefan
next prev parent reply other threads:[~2016-02-08 21:39 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20160208185311.9470.7389@vcs.savannah.gnu.org>
[not found] ` <E1aSqvv-0002TM-Vt@vcs.savannah.gnu.org>
2016-02-08 19:55 ` [Emacs-diffs] master de76a16: Performance improvements for vc-hg Stefan Monnier
2016-02-08 20:11 ` Daniel Colascione
2016-02-08 20:21 ` Eli Zaretskii
2016-02-08 20:28 ` Daniel Colascione
2016-02-08 21:01 ` Eli Zaretskii
2016-02-08 21:09 ` Daniel Colascione
2016-02-08 21:39 ` Stefan Monnier [this message]
2016-02-08 22:02 ` VC's modeline Óscar Fuentes
2016-02-09 15:15 ` Stefan Monnier
2016-02-09 17:13 ` Óscar Fuentes
2016-02-10 15:16 ` Stefan Monnier
2016-02-13 20:01 ` Dmitry Gutov
2016-02-13 9:33 ` Markus Triska
2016-02-08 23:29 ` Daniel Colascione
2016-02-13 9:35 ` Markus Triska
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvmvragaav.fsf-monnier+emacsdiffs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=dancol@dancol.org \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.