From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.help Subject: Re: Help setting nadvice for indent-region Date: Thu, 11 Feb 2016 09:02:42 -0500 Message-ID: References: <87a8ne2k6v.fsf@web.de> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1455199540 7292 80.91.229.3 (11 Feb 2016 14:05:40 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 11 Feb 2016 14:05:40 +0000 (UTC) To: help-gnu-emacs@gnu.org Original-X-From: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane.org@gnu.org Thu Feb 11 15:05:31 2016 Return-path: Envelope-to: geh-help-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1aTrs9-00034o-6W for geh-help-gnu-emacs@m.gmane.org; Thu, 11 Feb 2016 15:05:29 +0100 Original-Received: from localhost ([::1]:50350 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aTrs8-0008VF-H6 for geh-help-gnu-emacs@m.gmane.org; Thu, 11 Feb 2016 09:05:28 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:60555) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aTrrr-0008Uz-PY for help-gnu-emacs@gnu.org; Thu, 11 Feb 2016 09:05:17 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aTrrm-0001LW-2r for help-gnu-emacs@gnu.org; Thu, 11 Feb 2016 09:05:11 -0500 Original-Received: from plane.gmane.org ([80.91.229.3]:40040) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aTrrl-0001L9-ST for help-gnu-emacs@gnu.org; Thu, 11 Feb 2016 09:05:06 -0500 Original-Received: from list by plane.gmane.org with local (Exim 4.69) (envelope-from ) id 1aTrrk-0002iR-0r for help-gnu-emacs@gnu.org; Thu, 11 Feb 2016 15:05:04 +0100 Original-Received: from 69-196-189-155.dsl.teksavvy.com ([69.196.189.155]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Thu, 11 Feb 2016 15:05:04 +0100 Original-Received: from monnier by 69-196-189-155.dsl.teksavvy.com with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Thu, 11 Feb 2016 15:05:04 +0100 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 25 Original-X-Complaints-To: usenet@ger.gmane.org X-Gmane-NNTP-Posting-Host: 69-196-189-155.dsl.teksavvy.com User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) Cancel-Lock: sha1:9h69OqCWmsTcSVY0K092nO80WMQ= X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 80.91.229.3 X-BeenThere: help-gnu-emacs@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Users list for the GNU Emacs text editor List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane.org@gnu.org Original-Sender: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.help:109102 Archived-At: > (defun modi/region-or-whole-advice (orig &rest _) > (interactive) > (if (use-region-p) > (funcall orig (region-beginning) (region-end)) > (funcall orig (point-min) (point-max)))) > (dolist (fn modi/region-or-whole-fns) > (advice-add fn :around #'modi/region-or-whole-advice)) This will affect all calls to these functions and is hence sure to cause some breakage somewhere. You want something more like: (defun modi/region-or-whole-advice (&rest _) (interactive (if (use-region-p) (list (region-beginning) (region-end)) (list (point-min) (point-max)))) nil) (dolist (fn modi/region-or-whole-fns) (advice-add fn :before #'modi/region-or-whole-advice)) So you only modify the interactive spec (i.e. change the *command*'s behavior) without changing the *function*'s behavior. -- Stefan