Re: Help setting nadvice for indent-region

[Stefan Monnier <monnier@iro.umontreal.ca>]

> (defun modi/region-or-whole-advice (orig &rest _)
>   (interactive)
>   (if (use-region-p)
>       (funcall orig (region-beginning) (region-end))
>     (funcall orig (point-min) (point-max))))
> (dolist (fn modi/region-or-whole-fns)
>   (advice-add fn :around #'modi/region-or-whole-advice))

This will affect all calls to these functions and is hence sure to cause
some breakage somewhere.  You want something more like:

    (defun modi/region-or-whole-advice (&rest _)
      (interactive
       (if (use-region-p)
           (list (region-beginning) (region-end))
        (list (point-min) (point-max))))
      nil)
    (dolist (fn modi/region-or-whole-fns)
      (advice-add fn :before #'modi/region-or-whole-advice))

So you only modify the interactive spec (i.e. change the *command*'s
behavior) without changing the *function*'s behavior.


-- Stefan