* Re: [Emacs-diffs] emacs-25 ccb75d7: Partially revert previous change.
[not found] ` <E1av5BD-0003c7-Rb@vcs.savannah.gnu.org>
@ 2016-04-27 0:03 ` Stefan Monnier
2016-04-27 0:13 ` Mark Oteiza
0 siblings, 1 reply; 2+ messages in thread
From: Stefan Monnier @ 2016-04-27 0:03 UTC (permalink / raw)
To: emacs-devel; +Cc: Mark Oteiza
> --- a/lisp/rect.el
> +++ b/lisp/rect.el
> @@ -783,7 +783,7 @@ Ignores `line-move-visual'."
> (if (not old)
> (let ((ol (make-overlay left right)))
> (overlay-put ol 'window window)
> - (overlay-put ol 'face 'rectangle-preview)
> + (overlay-put ol 'face 'region)
> ol)
> (let ((ol (pop old)))
> (move-overlay ol left right (current-buffer))
Shouldn't the other uses of `rectangle-preview' in
rectangle--highlight-for-redisplay also be reverted?
Stefan
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [Emacs-diffs] emacs-25 ccb75d7: Partially revert previous change.
2016-04-27 0:03 ` [Emacs-diffs] emacs-25 ccb75d7: Partially revert previous change Stefan Monnier
@ 2016-04-27 0:13 ` Mark Oteiza
0 siblings, 0 replies; 2+ messages in thread
From: Mark Oteiza @ 2016-04-27 0:13 UTC (permalink / raw)
To: Stefan Monnier; +Cc: emacs-devel
On 26/04/16 at 08:03pm, Stefan Monnier wrote:
> > --- a/lisp/rect.el
> > +++ b/lisp/rect.el
> > @@ -783,7 +783,7 @@ Ignores `line-move-visual'."
> > (if (not old)
> > (let ((ol (make-overlay left right)))
> > (overlay-put ol 'window window)
> > - (overlay-put ol 'face 'rectangle-preview)
> > + (overlay-put ol 'face 'region)
> > ol)
> > (let ((ol (pop old)))
> > (move-overlay ol left right (current-buffer))
>
> Shouldn't the other uses of `rectangle-preview' in
> rectangle--highlight-for-redisplay also be reverted?
Probably. Hopefully all fixed now.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-04-27 0:13 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20160426154539.13857.91834@vcs.savannah.gnu.org>
[not found] ` <E1av5BD-0003c7-Rb@vcs.savannah.gnu.org>
2016-04-27 0:03 ` [Emacs-diffs] emacs-25 ccb75d7: Partially revert previous change Stefan Monnier
2016-04-27 0:13 ` Mark Oteiza
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.