From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] emacs-25 ccb75d7: Partially revert previous change. Date: Tue, 26 Apr 2016 20:03:34 -0400 Message-ID: References: <20160426154539.13857.91834@vcs.savannah.gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1461715447 10319 80.91.229.3 (27 Apr 2016 00:04:07 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 27 Apr 2016 00:04:07 +0000 (UTC) Cc: Mark Oteiza To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Apr 27 02:03:54 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1avCxN-00081Q-Vc for ged-emacs-devel@m.gmane.org; Wed, 27 Apr 2016 02:03:54 +0200 Original-Received: from localhost ([::1]:40157 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1avCxN-0005SI-9V for ged-emacs-devel@m.gmane.org; Tue, 26 Apr 2016 20:03:53 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:43018) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1avCx9-0005Pe-8s for emacs-devel@gnu.org; Tue, 26 Apr 2016 20:03:39 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1avCx6-0007vm-3J for emacs-devel@gnu.org; Tue, 26 Apr 2016 20:03:39 -0400 Original-Received: from pruche.dit.umontreal.ca ([132.204.246.22]:47136) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1avCx5-0007vZ-Tw for emacs-devel@gnu.org; Tue, 26 Apr 2016 20:03:36 -0400 Original-Received: from fmsmemgm.homelinux.net (lechon.iro.umontreal.ca [132.204.27.242]) by pruche.dit.umontreal.ca (8.14.7/8.14.1) with ESMTP id u3R03YAB023760; Tue, 26 Apr 2016 20:03:34 -0400 Original-Received: by fmsmemgm.homelinux.net (Postfix, from userid 20848) id 0E54EAE132; Tue, 26 Apr 2016 20:03:34 -0400 (EDT) In-Reply-To: (Mark Oteiza's message of "Tue, 26 Apr 2016 15:45:39 +0000") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 1 Rules triggered RV5654=0 X-NAI-Spam-Version: 2.3.0.9418 : core <5654> : inlines <4722> : streams <1625849> : uri <2197361> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 132.204.246.22 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:203369 Archived-At: > --- a/lisp/rect.el > +++ b/lisp/rect.el > @@ -783,7 +783,7 @@ Ignores `line-move-visual'." > (if (not old) > (let ((ol (make-overlay left right))) > (overlay-put ol 'window window) > - (overlay-put ol 'face 'rectangle-preview) > + (overlay-put ol 'face 'region) > ol) > (let ((ol (pop old))) > (move-overlay ol left right (current-buffer)) Shouldn't the other uses of `rectangle-preview' in rectangle--highlight-for-redisplay also be reverted? Stefan