From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#23917: Please consider making Bug #23917 a blocker for 25.1 (was Re: org-capture: Capture template =?UTF-8?Q?=E2=80=98g=E2=80=99:?= Match data clobbered by buffer modification hooks) Date: Mon, 18 Jul 2016 20:58:35 -0400 Message-ID: References: <87vb066ejv.fsf@linaro.org> <8360s67qcp.fsf@gnu.org> <87bn1yyaui.fsf@linaro.org> <87mvlhmv0x.fsf_-_@moondust.awandering> <837fcl5zs9.fsf@gnu.org> <87a8hgkwcb.fsf@linaro.org> <8360s42mcb.fsf@gnu.org> <87eg6rgmlg.fsf@gmail.com> <83lh0y24y6.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1468889974 23885 80.91.229.3 (19 Jul 2016 00:59:34 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 19 Jul 2016 00:59:34 +0000 (UTC) Cc: 23917@debbugs.gnu.org, Robert Pluim , jwiegley@gmail.com, alex.bennee@linaro.org, nljlistbox2@gmail.com To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Jul 19 02:59:22 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1bPJNX-0003UC-AQ for geb-bug-gnu-emacs@m.gmane.org; Tue, 19 Jul 2016 02:59:19 +0200 Original-Received: from localhost ([::1]:51295 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bPJNW-0008NG-Cg for geb-bug-gnu-emacs@m.gmane.org; Mon, 18 Jul 2016 20:59:18 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:57941) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bPJNM-0008Bw-RX for bug-gnu-emacs@gnu.org; Mon, 18 Jul 2016 20:59:09 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bPJNL-00067y-38 for bug-gnu-emacs@gnu.org; Mon, 18 Jul 2016 20:59:08 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:43779) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bPJNF-00067B-RM; Mon, 18 Jul 2016 20:59:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1bPJNF-0001Eu-Kn; Mon, 18 Jul 2016 20:59:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org, emacs-orgmode@gnu.org Resent-Date: Tue, 19 Jul 2016 00:59:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 23917 X-GNU-PR-Package: emacs,org-mode X-GNU-PR-Keywords: Original-Received: via spool by 23917-submit@debbugs.gnu.org id=B23917.14688899224740 (code B ref 23917); Tue, 19 Jul 2016 00:59:01 +0000 Original-Received: (at 23917) by debbugs.gnu.org; 19 Jul 2016 00:58:42 +0000 Original-Received: from localhost ([127.0.0.1]:56116 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bPJMw-0001EO-KU for submit@debbugs.gnu.org; Mon, 18 Jul 2016 20:58:42 -0400 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.181]:64143) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bPJMv-0001EC-QP for 23917@debbugs.gnu.org; Mon, 18 Jul 2016 20:58:42 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: A0AjDgA731xV/3mcpUVcgxCEAghGyBIEAgKBPD0QAQEBAQEBAYEKQQWDXQEBAwEMFzMjBQsJAhoCGAcHAgIUGA0TEYg3CI18nRCkFwEBCAIBH4EhihmEUjMHgmiBRQEEkDSOY4NrkD2BRSOBZiQcFYFZIoJ4AQEB X-IPAS-Result: A0AjDgA731xV/3mcpUVcgxCEAghGyBIEAgKBPD0QAQEBAQEBAYEKQQWDXQEBAwEMFzMjBQsJAhoCGAcHAgIUGA0TEYg3CI18nRCkFwEBCAIBH4EhihmEUjMHgmiBRQEEkDSOY4NrkD2BRSOBZiQcFYFZIoJ4AQEB X-IronPort-AV: E=Sophos;i="5.13,465,1427774400"; d="scan'208";a="248457055" Original-Received: from 69-165-156-121.dsl.teksavvy.com (HELO fmsmemgm.homelinux.net) ([69.165.156.121]) by ironport2-out.teksavvy.com with ESMTP/TLS/DHE-RSA-AES256-SHA; 18 Jul 2016 20:58:36 -0400 Original-Received: by fmsmemgm.homelinux.net (Postfix, from userid 20848) id B5141AE2BB; Mon, 18 Jul 2016 20:58:35 -0400 (EDT) In-Reply-To: <83lh0y24y6.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 18 Jul 2016 21:09:53 +0300") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:121247 Archived-At: > In the case in point, a single character at EOB (=3D 62) was deleted, > which made EOB be 61, one less than its previous value. When > save-match-data was called from within a hook set up by Org, it tried > to record the end of the sub-expression as 62, but set-marker silently > changed that to 61. That "corrected" value was subsequently restored > when save-match-data was exited, whereas replace-match expected to see > the original value of 62, and therefore barfed. I think this change performed by save-match-data is harmless: the old value (62) was not valid any more anyway. So I think a safe fix is to try and relax the check we added to replace-match so it doesn't get all worked up when something =E2=89=A5 EOB = gets changed to something else that's also =E2=89=A5 EOB. Or maybe instead of signaling an error, we could simply skip the "Adjust search data for this change". I like the idea of signaling an error, as a debugging help, but maybe for emacs-25 we should go for something less intrusive after all? This said, I don't fully understand what's going on: bug#23869 reported a crash, but AFAICT the match-data here is only used to adjust search_regs which seems like it wouldn't cause a crash, even if the new values are bogus. So maybe signaling an error is important because the crash happens further down. > - '((save-match-data-internal (match-data))) > + '((save-match-data-internal (match-data 'integers))) That looks risky. Stefan