From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: emacs coding modes need 'Suspend Disbelief' button Date: Fri, 23 Jun 2017 17:11:01 -0400 Message-ID: References: <83shk12is5.fsf@gnu.org> <87r2zbzquk.fsf@zigzag> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1498252286 31668 195.159.176.226 (23 Jun 2017 21:11:26 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 23 Jun 2017 21:11:26 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Jun 23 23:11:22 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dOVrK-0007qu-NC for ged-emacs-devel@m.gmane.org; Fri, 23 Jun 2017 23:11:18 +0200 Original-Received: from localhost ([::1]:37277 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dOVrP-0004cM-Sb for ged-emacs-devel@m.gmane.org; Fri, 23 Jun 2017 17:11:23 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:46462) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dOVrI-0004cG-Sg for emacs-devel@gnu.org; Fri, 23 Jun 2017 17:11:18 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dOVrE-0004AD-US for emacs-devel@gnu.org; Fri, 23 Jun 2017 17:11:16 -0400 Original-Received: from [195.159.176.226] (port=44057 helo=blaine.gmane.org) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dOVrE-000492-OT for emacs-devel@gnu.org; Fri, 23 Jun 2017 17:11:12 -0400 Original-Received: from list by blaine.gmane.org with local (Exim 4.84_2) (envelope-from ) id 1dOVr5-00074y-FV for emacs-devel@gnu.org; Fri, 23 Jun 2017 23:11:03 +0200 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 30 Original-X-Complaints-To: usenet@blaine.gmane.org Cancel-Lock: sha1:NQnv918L0Ud7ar8GXZpSWhCnB8Q= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 195.159.176.226 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:215917 Archived-At: > ((argc > 2) && (argv[3]!=NULL) && > (argv[3][0]=='u'))?U::RTNL::RT::Type_t::RT_UNICAST:( > ((argc > 2) && (argv[3]!=NULL) && > (argv[3][0]=='l'))?U::RTNL::RT::Type_t::RT_LOCAL:( > ((argc > 2) && (argv[3]!=NULL) && > (argv[3][0]=='b'))?U::RTNL::RT::Type_t::RT_BROADCAST:( > ((argc > 2) && (argv[3]!=NULL) && > (argv[3][0]=='a'))?U::RTNL::RT::Type_t::RT_ANYCAST:( > ((argc > 2) && (argv[3]!=NULL) && > (argv[3][0]=='a'))?U::RTNL::RT::Type_t::RT_ANYCAST:( > An attempt to add another clause with Emacs c++-mode enabled > fairly reliably results in a core dump. Sorry, no core dump here. But that code sure looks hideous. Is that machine-generated code, maybe? I'd be strongly tempted to rewrite along the lines of if ((argc <= 2) || (argv[3] == NULL)) else switch (argv[3][0]) { case 'u': return U::RTNL::RT::Type_t::RT_UNICAST; case 'l': return U::RTNL::RT::Type_t::RT_LOCAL; ... } -- Stefan