From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] master a2ee819: Let delete-selection-mode work with popup-menu commands (Bug#27569) Date: Tue, 18 Jul 2017 13:28:18 -0400 Message-ID: References: <20170718103950.22436.83344@vcs0.savannah.gnu.org> <20170718103952.4E6F720E35@vcs0.savannah.gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit X-Trace: blaine.gmane.org 1500399030 32726 195.159.176.226 (18 Jul 2017 17:30:30 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 18 Jul 2017 17:30:30 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Jul 18 19:30:25 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dXWKD-0008CP-Sr for ged-emacs-devel@m.gmane.org; Tue, 18 Jul 2017 19:30:21 +0200 Original-Received: from localhost ([::1]:57950 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dXWKJ-0004pO-HU for ged-emacs-devel@m.gmane.org; Tue, 18 Jul 2017 13:30:27 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:43138) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dXWK8-0004nO-D9 for emacs-devel@gnu.org; Tue, 18 Jul 2017 13:30:18 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dXWK5-00059M-8K for emacs-devel@gnu.org; Tue, 18 Jul 2017 13:30:16 -0400 Original-Received: from [195.159.176.226] (port=53060 helo=blaine.gmane.org) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dXWK5-00058q-0l for emacs-devel@gnu.org; Tue, 18 Jul 2017 13:30:13 -0400 Original-Received: from list by blaine.gmane.org with local (Exim 4.84_2) (envelope-from ) id 1dXWJw-0007L1-Be for emacs-devel@gnu.org; Tue, 18 Jul 2017 19:30:04 +0200 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 20 Original-X-Complaints-To: usenet@blaine.gmane.org Cancel-Lock: sha1:wm+Wn4OpBJLwFB/yLdz532Cw0rk= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 195.159.176.226 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:216852 Archived-At: >>> + ;; Update `this-command' and run `pre-command-hook' so that >>> + ;; things like `delete-selection-pre-hook' will work correctly. >>> + (setq this-command cmd) >>> + (run-hooks 'pre-command-hook) >>> ;; mouse-major-mode-menu was using `command-execute' instead. >>> (call-interactively cmd)))) >> >> Hmm... shouldn't it then also run post-command-hook, and set >> last-command (and probably a few more of the things done in the usual >> command loop, such as handling undo-boundaries)? > I'm not sure, won't we end up with 1 1/2 of the command stuff done in > that case? (the half being the popup-menu we began executing to get > here). AFAICT the current case is the one that ends up with 1½ done. What I suggest is to bring it back to a whole number (i.e. 2). Stefan