From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] scratch/flymake-refactor b75f7e2: Hook Flymake onto proper checkdoc and byte-compile interfaces Date: Sun, 01 Oct 2017 23:14:53 -0400 Message-ID: References: <20171001123811.5647.26035@vcs0.savannah.gnu.org> <20171001123812.A22F12068C@vcs0.savannah.gnu.org> <87tvzigzd3.fsf@lolita> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1506914139 3740 195.159.176.226 (2 Oct 2017 03:15:39 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 2 Oct 2017 03:15:39 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Oct 02 05:15:36 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dyrCh-0000WB-BN for ged-emacs-devel@m.gmane.org; Mon, 02 Oct 2017 05:15:35 +0200 Original-Received: from localhost ([::1]:50444 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dyrCo-00052o-On for ged-emacs-devel@m.gmane.org; Sun, 01 Oct 2017 23:15:42 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:45754) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dyrCC-00052W-FZ for emacs-devel@gnu.org; Sun, 01 Oct 2017 23:15:05 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dyrC9-000061-8f for emacs-devel@gnu.org; Sun, 01 Oct 2017 23:15:04 -0400 Original-Received: from [195.159.176.226] (port=38849 helo=blaine.gmane.org) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dyrC9-0008Uc-1i for emacs-devel@gnu.org; Sun, 01 Oct 2017 23:15:01 -0400 Original-Received: from list by blaine.gmane.org with local (Exim 4.84_2) (envelope-from ) id 1dyrBy-00057t-TE for emacs-devel@gnu.org; Mon, 02 Oct 2017 05:14:50 +0200 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 19 Original-X-Complaints-To: usenet@blaine.gmane.org Cancel-Lock: sha1:JXk6zXq1I4/eqOPExTH5pl4NhCU= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 195.159.176.226 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:219000 Archived-At: >>> * lisp/emacs-lisp/bytecomp.el >>> (byte-compile-log-warning-function): New variable. >>> (byte-compile-log-warning): Use it. >>> (byte-compile--log-warning-for-byte-compile): New function. >> Looking at it, I think it'd be more useful to add >> a `display-warning-function` which applies to all calls to >> display-warning. > OTOH, we're not exactly "displaying" a warning, we're collecting one. I'm just pointing out that moving the hook from byte-compile-log-warning to display-warning would make it more generally useful. > No problem. As I think I said in the commit message these two "proper" > interfaces are just pure boilerplate. Feel free to change them. I think for checkdoc, the hook looks good enough. Stefan