Re: [Emacs-diffs] scratch/flymake-refactor b75f7e2: Hook Flymake onto proper checkdoc and byte-compile interfaces

Re: [Emacs-diffs] scratch/flymake-refactor b75f7e2: Hook Flymake onto proper checkdoc and byte-compile interfaces

[Stefan Monnier]

> * lisp/emacs-lisp/bytecomp.el
> (byte-compile-log-warning-function): New variable.
> (byte-compile-log-warning): Use it.
> (byte-compile--log-warning-for-byte-compile): New function.

Looking at it, I think it'd be more useful to add
a `display-warning-function` which applies to all calls to display-warning.

> * lisp/emacs-lisp/checkdoc.el
> (checkdoc-create-error-function): New variable.
> (checkdoc-create-error): Use it.
> (checkdoc--create-error-for-checkdoc): New function.xo

As for this one, I see that checkdoc-create-error can be either
"declarative" (it just builds an object, with no side-effect) or not
depending on checkdoc-generate-compile-warnings-flag.
This sounds like checkdoc already has some of the design we need (it
can construct error objects and then return them), but maybe some more
serious refactoring would be needed to make it really work for flymake.
No time to look deeper into it now,


        Stefan

Re: [Emacs-diffs] scratch/flymake-refactor b75f7e2: Hook Flymake onto proper checkdoc and byte-compile interfaces

[João Távora]

Stefan Monnier <monnier@iro.umontreal.ca> writes:

>> * lisp/emacs-lisp/bytecomp.el
>> (byte-compile-log-warning-function): New variable.
>> (byte-compile-log-warning): Use it.
>> (byte-compile--log-warning-for-byte-compile): New function.
>
> Looking at it, I think it'd be more useful to add
> a `display-warning-function` which applies to all calls to
> display-warning.

OTOH, we're not exactly "displaying" a warning, we're collecting one.

>> * lisp/emacs-lisp/checkdoc.el
>> (checkdoc-create-error-function): New variable.
>> (checkdoc-create-error): Use it.
>> (checkdoc--create-error-for-checkdoc): New function.xo
>
> As for this one, I see that checkdoc-create-error can be either
> "declarative" (it just builds an object, with no side-effect) or not
> depending on checkdoc-generate-compile-warnings-flag.
> This sounds like checkdoc already has some of the design we need (it
> can construct error objects and then return them), but maybe some more
> serious refactoring would be needed to make it really work for flymake.
> No time to look deeper into it now,

No problem. As I think I said in the commit message these two "proper"
interfaces are just pure boilerplate. Feel free to change them.

João

Re: [Emacs-diffs] scratch/flymake-refactor b75f7e2: Hook Flymake onto proper checkdoc and byte-compile interfaces

[Stefan Monnier]

>>> * lisp/emacs-lisp/bytecomp.el
>>> (byte-compile-log-warning-function): New variable.
>>> (byte-compile-log-warning): Use it.
>>> (byte-compile--log-warning-for-byte-compile): New function.
>> Looking at it, I think it'd be more useful to add
>> a `display-warning-function` which applies to all calls to
>> display-warning.
> OTOH, we're not exactly "displaying" a warning, we're collecting one.

I'm just pointing out that moving the hook from byte-compile-log-warning
to display-warning would make it more generally useful.

> No problem. As I think I said in the commit message these two "proper"
> interfaces are just pure boilerplate. Feel free to change them.

I think for checkdoc, the hook looks good enough.


        Stefan