From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#30635: No compiler warning if code forgets to require cl-lib Date: Thu, 22 Mar 2018 17:53:01 -0400 Message-ID: References: NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1521755532 14725 195.159.176.226 (22 Mar 2018 21:52:12 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 22 Mar 2018 21:52:12 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: 30635@debbugs.gnu.org To: Glenn Morris Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Mar 22 22:52:08 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ez87z-0003gn-E9 for geb-bug-gnu-emacs@m.gmane.org; Thu, 22 Mar 2018 22:52:07 +0100 Original-Received: from localhost ([::1]:35026 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ez8A0-0002rc-U7 for geb-bug-gnu-emacs@m.gmane.org; Thu, 22 Mar 2018 17:54:12 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:52243) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ez89u-0002pO-U8 for bug-gnu-emacs@gnu.org; Thu, 22 Mar 2018 17:54:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ez89r-0000xs-0O for bug-gnu-emacs@gnu.org; Thu, 22 Mar 2018 17:54:07 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:40291) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ez89q-0000xU-T4 for bug-gnu-emacs@gnu.org; Thu, 22 Mar 2018 17:54:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ez89q-0006xx-Fa for bug-gnu-emacs@gnu.org; Thu, 22 Mar 2018 17:54:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 22 Mar 2018 21:54:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 30635 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 30635-submit@debbugs.gnu.org id=B30635.152175558626702 (code B ref 30635); Thu, 22 Mar 2018 21:54:02 +0000 Original-Received: (at 30635) by debbugs.gnu.org; 22 Mar 2018 21:53:06 +0000 Original-Received: from localhost ([127.0.0.1]:48185 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ez88v-0006wc-MA for submit@debbugs.gnu.org; Thu, 22 Mar 2018 17:53:05 -0400 Original-Received: from pruche.dit.umontreal.ca ([132.204.246.22]:34444) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ez88t-0006wU-De for 30635@debbugs.gnu.org; Thu, 22 Mar 2018 17:53:04 -0400 Original-Received: from pastel.home (lechon.iro.umontreal.ca [132.204.27.242]) by pruche.dit.umontreal.ca (8.14.7/8.14.1) with ESMTP id w2MLr1L9006733; Thu, 22 Mar 2018 17:53:02 -0400 Original-Received: by pastel.home (Postfix, from userid 20848) id 6EA3E604C8; Thu, 22 Mar 2018 17:53:01 -0400 (EDT) In-Reply-To: (Glenn Morris's message of "Mon, 19 Mar 2018 16:12:28 -0400") X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 2 Rules triggered EDT_SA_DN_PASS=0, RV6248=0 X-NAI-Spam-Version: 2.3.0.9418 : core <6248> : inlines <6514> : streams <1781970> : uri <2613021> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:144536 Archived-At: >>> There's no compiler warning if a library uses cl-lib without requiring it. >>> I assume this is because bytecomp.el requires cl-lib. >> Should we apply the patch below? > Works for me, thanks. Doesn't work for me, OTOH: % src/emacs --batch --eval "(eval-after-load 'cl-lib '(debug t))" -f batch-byte-compile lisp/emacs-lisp/bytecomp.el Debugger entered--beginning evaluation of function call form: (lambda nil (debug t))() eval-after-load-helper("/home/monnier/src/emacs/trunk/lisp/emacs-lisp/cl-lib.elc") run-hook-with-args(eval-after-load-helper "/home/monnier/src/emacs/trunk/lisp/emacs-lisp/cl-lib.elc") do-after-load-evaluation("/home/monnier/src/emacs/trunk/lisp/emacs-lisp/cl-lib.elc") require(cl-lib) require(seq) require(map) dir-locals-read-from-dir("/home/monnier/src/emacs/trunk/") hack-dir-local-variables() hack-local-variables(no-mode) normal-mode(t) byte-compile-file("lisp/emacs-lisp/bytecomp.el") batch-byte-compile-file("lisp/emacs-lisp/bytecomp.el") batch-byte-compile() command-line-1(("--eval" "(eval-after-load 'cl-lib '(debug t))" "-f" "batch-byte-compile" "lisp/emacs-lisp/bytecomp.el")) command-line() normal-top-level() and if you look at `dir-locals-read-from-dir`, you'll see that it does (require 'map) and then uses its `map-merge(-with)`. Stefan "the pressure to preload cl-lib is definitely mounting"