From: Stefan Monnier <monnier@IRO.UMontreal.CA>
To: Glenn Morris <rgm@gnu.org>
Cc: 30635@debbugs.gnu.org
Subject: bug#30635: No compiler warning if code forgets to require cl-lib
Date: Thu, 22 Mar 2018 17:53:01 -0400 [thread overview]
Message-ID: <jwvmuyzu6gy.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <o1lgenhljn.fsf@fencepost.gnu.org> (Glenn Morris's message of "Mon, 19 Mar 2018 16:12:28 -0400")
>>> There's no compiler warning if a library uses cl-lib without requiring it.
>>> I assume this is because bytecomp.el requires cl-lib.
>> Should we apply the patch below?
> Works for me, thanks.
Doesn't work for me, OTOH:
% src/emacs --batch --eval "(eval-after-load 'cl-lib '(debug t))" -f batch-byte-compile lisp/emacs-lisp/bytecomp.el
Debugger entered--beginning evaluation of function call form:
(lambda nil (debug t))()
eval-after-load-helper("/home/monnier/src/emacs/trunk/lisp/emacs-lisp/cl-lib.elc")
run-hook-with-args(eval-after-load-helper "/home/monnier/src/emacs/trunk/lisp/emacs-lisp/cl-lib.elc")
do-after-load-evaluation("/home/monnier/src/emacs/trunk/lisp/emacs-lisp/cl-lib.elc")
require(cl-lib)
require(seq)
require(map)
dir-locals-read-from-dir("/home/monnier/src/emacs/trunk/")
hack-dir-local-variables()
hack-local-variables(no-mode)
normal-mode(t)
byte-compile-file("lisp/emacs-lisp/bytecomp.el")
batch-byte-compile-file("lisp/emacs-lisp/bytecomp.el")
batch-byte-compile()
command-line-1(("--eval" "(eval-after-load 'cl-lib '(debug t))" "-f" "batch-byte-compile" "lisp/emacs-lisp/bytecomp.el"))
command-line()
normal-top-level()
and if you look at `dir-locals-read-from-dir`, you'll see that it does
(require 'map) and then uses its `map-merge(-with)`.
Stefan "the pressure to preload cl-lib is definitely mounting"
next prev parent reply other threads:[~2018-03-22 21:53 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-27 18:45 bug#30635: No compiler warning if code forgets to require cl-lib Glenn Morris
2018-03-19 19:58 ` Stefan Monnier
2018-03-19 20:12 ` Glenn Morris
2018-03-22 21:53 ` Stefan Monnier [this message]
2018-03-22 22:19 ` Stefan Monnier
2018-03-23 0:56 ` Glenn Morris
2018-03-26 0:51 ` Basil L. Contovounesios
2018-03-26 1:30 ` Basil L. Contovounesios
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvmuyzu6gy.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=30635@debbugs.gnu.org \
--cc=rgm@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.