From: Stefan Monnier <monnier@IRO.UMontreal.CA>
To: Alan Mackenzie <acm@muc.de>
Cc: emacs-devel@gnu.org
Subject: Re: An idea: combine-change-calls
Date: Sun, 25 Mar 2018 16:05:40 -0400 [thread overview]
Message-ID: <jwvmuyworvh.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <20180325191424.GE6292@ACM> (Alan Mackenzie's message of "Sun, 25 Mar 2018 19:14:24 +0000")
> I've actually got a working implementation going. It is this:
>
> (defmacro combine-change-calls (beg end &rest form)
> `(if (not inhibit-modification-hooks)
> (let* ((-beg- ,beg) (-end- ,end)
> (end-marker (copy-marker -end-)))
> (run-hook-with-args 'before-change-functions beg end)
> (let ((inhibit-modification-hooks t))
> ,@form)
> (run-hook-with-args 'after-change-functions
> beg (marker-position end-marker)
> (- -end- -beg-)))
> ,@form))
You need to evaluate `beg` and `end` even if inhibit-modification-hooks
is set, otherwise someone will get bitten.
I recommend you move the `form` to a lambda so you don't have to
duplicate it:
`(let ((body (lambda () ,@form))
(-beg- ,beg)
(-end- ,end))
...)
Another benefit is that by moving `form` outside of the `let*`, you
won't need to use gensym/make-symbol nor obfuscated names.
I'd also recommend you check that `beg` hasn't changed position and that
the distance between end-marker and point-max remained the same.
>> Maybe combine-change-calls should also combine all those changes on the
>> undo-list into a big "delete+insert" (of course, it could also try and
>> keep the undo granularity but mark those undo entries so that they're
>> undone within their own combine-change-calls).
> :-) Either of those would be quite a project, but possibly worth doing.
Replacing the entries with a pair of delete+insert should be
pretty easy. Something like
(let ((old-buffer-undo-list buffer-undo-list)
(orig-text (buffer-substring beg end)))
...
(setq buffer-undo-list
`((,(marker-position end-marker) ,beg)
(,orig-text . ,beg)
. ,old-buffer-undo-list)))
modulo sanity checks (i.e. don't do it if undo is disabled and don't do
it if old-buffer-undo-list is not within buffer-undo-list any more).
Stefan
next prev parent reply other threads:[~2018-03-25 20:05 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-24 13:50 An idea: combine-change-calls Alan Mackenzie
2018-03-24 22:18 ` Stefan Monnier
2018-03-25 19:14 ` Alan Mackenzie
2018-03-25 20:05 ` Stefan Monnier [this message]
2018-03-26 20:17 ` Alan Mackenzie
2018-03-26 21:07 ` Stefan Monnier
2018-03-27 16:58 ` Alan Mackenzie
2018-03-27 18:30 ` Stefan Monnier
2018-03-27 19:45 ` Alan Mackenzie
2018-03-27 20:24 ` Stefan Monnier
2018-03-28 20:42 ` Alan Mackenzie
2018-03-28 21:26 ` Stefan Monnier
2018-03-29 15:10 ` Alan Mackenzie
2018-03-29 15:40 ` Stefan Monnier
2018-03-29 17:11 ` Alan Mackenzie
2018-03-29 19:10 ` Stefan Monnier
2018-03-30 11:46 ` Alan Mackenzie
2018-03-30 15:05 ` Stefan Monnier
2018-03-31 21:00 ` Alan Mackenzie
2018-03-31 23:38 ` Stefan Monnier
2018-04-01 14:24 ` Alan Mackenzie
2018-04-01 19:22 ` Stefan Monnier
2018-03-30 9:12 ` Johan Bockgård
2018-03-30 13:04 ` Stefan Monnier
2018-04-02 16:25 ` Alan Mackenzie
2018-04-02 17:52 ` Johan Bockgård
2018-04-03 0:41 ` Stefan Monnier
2018-04-03 1:43 ` Clément Pit-Claudel
2018-04-03 3:15 ` Richard Stallman
2018-03-26 21:09 ` Stefan Monnier
2018-03-27 0:36 ` Stefan Monnier
2018-03-27 17:00 ` Alan Mackenzie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvmuyworvh.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=acm@muc.de \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.