From: Stefan Monnier <monnier@IRO.UMontreal.CA>
To: emacs-devel@gnu.org
Cc: John Shahid <jvshahid@gmail.com>
Subject: Re: [Emacs-diffs] emacs-26 35e0305: Avoid turning on the global-minor-mode recursively
Date: Tue, 10 Jul 2018 09:42:26 -0400 [thread overview]
Message-ID: <jwvmuuz9pll.fsf-monnier+emacsdiffs@gnu.org> (raw)
In-Reply-To: <20180710121716.D4670204EE@vcs0.savannah.gnu.org> (Noam Postavsky's message of "Tue, 10 Jul 2018 08:17:16 -0400 (EDT)")
> + (let ((buffers ,MODE-buffers))
> + ;; Clear MODE-buffers to avoid scanning the same list of
> + ;; buffers in recursive calls to MODE-enable-in-buffers.
> + ;; Otherwise it could lead to infinite recursion.
> + (setq ,MODE-buffers nil)
> + (dolist (buf buffers)
Thanks.
BTW, in most other places where we need to "extract the content" of
a worklist like above, we do it with something like:
(... (prog1 FOO (setq FOO nil)) ...)
-- Stefan
next parent reply other threads:[~2018-07-10 13:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20180710121715.23096.25536@vcs0.savannah.gnu.org>
[not found] ` <20180710121716.D4670204EE@vcs0.savannah.gnu.org>
2018-07-10 13:42 ` Stefan Monnier [this message]
2018-07-10 20:07 ` [Emacs-diffs] emacs-26 35e0305: Avoid turning on the global-minor-mode recursively John Shahid
2018-07-10 20:35 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvmuuz9pll.fsf-monnier+emacsdiffs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=emacs-devel@gnu.org \
--cc=jvshahid@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.