From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#36431: Crash in marker.c:337 Date: Sun, 30 Jun 2019 10:59:09 -0400 Message-ID: References: <20190629.131734.877718102639559715.wl@gnu.org> <831rzch9nd.fsf@gnu.org> <83zhm0fuqg.fsf@gnu.org> <83ftnrf87e.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="96141"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: 36431@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Jun 30 17:00:13 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hhbJM-000Os7-RX for geb-bug-gnu-emacs@m.gmane.org; Sun, 30 Jun 2019 17:00:13 +0200 Original-Received: from localhost ([::1]:45048 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hhbJL-0002nc-MS for geb-bug-gnu-emacs@m.gmane.org; Sun, 30 Jun 2019 11:00:11 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:59928) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hhbJD-0002nJ-ED for bug-gnu-emacs@gnu.org; Sun, 30 Jun 2019 11:00:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hhbJC-0002JJ-HP for bug-gnu-emacs@gnu.org; Sun, 30 Jun 2019 11:00:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:33562) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hhbJC-0002IL-DI for bug-gnu-emacs@gnu.org; Sun, 30 Jun 2019 11:00:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hhbJC-0005T9-9Z for bug-gnu-emacs@gnu.org; Sun, 30 Jun 2019 11:00:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 30 Jun 2019 15:00:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 36431 X-GNU-PR-Package: emacs Original-Received: via spool by 36431-submit@debbugs.gnu.org id=B36431.156190676620946 (code B ref 36431); Sun, 30 Jun 2019 15:00:02 +0000 Original-Received: (at 36431) by debbugs.gnu.org; 30 Jun 2019 14:59:26 +0000 Original-Received: from localhost ([127.0.0.1]:47106 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hhbIb-0005Rm-Vm for submit@debbugs.gnu.org; Sun, 30 Jun 2019 10:59:26 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:9070) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hhbIZ-0005RX-JF for 36431@debbugs.gnu.org; Sun, 30 Jun 2019 10:59:24 -0400 Original-Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 1AD6181157; Sun, 30 Jun 2019 10:59:18 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id D3C0F81152; Sun, 30 Jun 2019 10:59:12 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1561906752; bh=GCFdPsYDv/My2hrvot7/vqjui97Ij2bkhY4ZHTuo7VE=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=dI6rTP38d035tjUpeNcsDPjmnrKU8fkCAueW2ai2ml1zshSMBhJ5qWkd0nnPRNSQ3 H+gopZyLEHvK08+5CzO8QTZ+I50JdE5FCPy3ga7Aml1n9HI2gevn2UklvbqL4wt/JN Od2mzw9u05ohBgyLWknFQQIiCThc+rh1N9Mr+oYHMsi4qTUMgh95C4wcCa7AvIBKfH Ct9BOEb/CdU3t/6jCarbzItvx4qapoFmz7JwfFlVSC9/zUaqJFMSCrCSynxHDdH/RZ wHLDWqvgp8MCXtYPxl6fm/WZqcEvJUo78N1JhAIGL6bsrU9OZf/lnBc3M+1dcKywtR 4VPyXmqOsSDHQ== Original-Received: from pastel (76-10-151-214.dsl.teksavvy.com [76.10.151.214]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 1EA5912020E; Sun, 30 Jun 2019 10:59:12 -0400 (EDT) In-Reply-To: <83ftnrf87e.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 30 Jun 2019 17:39:49 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:161888 Archived-At: > AFAICT, this patch moves the call to move_gap_both from a fragment > where we must decode the inserted text to a fragment where such a > decoding might not be necessary. If I'm right, then this makes > insert-file-contents slower in some cases, because moving the gap > might be very expensive with large buffers. Indeed, that's one of the problems, but there are more serious (correctness) problems with it anyway. > More generally, I'd be leery to make significant changes ion > insert-file-contents just to placate that single assertion. I'm still trying to really understand what the code is doing, but so far I get the impression that there are real bugs there, so I'm not really concerned with resolving the assertion but with fixing those bugs. Of course, to do that, I first need to understand the code (which maybe will convince me that there aren't any bugs after all). Stefan