From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Michael Albinus <michael.albinus@gmx.de>
Cc: emacs-devel@gnu.org, Dmitry Gutov <dgutov@yandex.ru>
Subject: Re: emacs-27 e1e0a7a 2/2: xref--collect-matches: Speed up on remote
Date: Fri, 27 Dec 2019 17:06:11 -0500 [thread overview]
Message-ID: <jwvmubds9wh.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <87imm1pllt.fsf@gmx.de> (Michael Albinus's message of "Fri, 27 Dec 2019 21:19:42 +0100")
>> It does go through Tramp for the initial `expand-file-name`, but AFAIK
>> this shouldn't need to talk to the remote host (unless it has a ~/ or
>> ~<user>/ in the remote part of the name, I guess?).
> That's how it is implemented, yes. However, remote file names with a
> relative localname part, are also expanded via prepending "~/" to the
> localname. For performance reasons it is better to avoid such file names.
In the context of `xref--collect-matches`, I'd expect the file name passed
to `get-file-buffer` to be either fully expanded file names or relative
file names (with a fully expanded `default-directory`), so in that case
`expand-file-name` should presumably "always" return without contacting
the remote host, right?
Stefan
next prev parent reply other threads:[~2019-12-27 22:06 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20191227141917.13328.16721@vcs0.savannah.gnu.org>
[not found] ` <20191227141919.03F1321537@vcs0.savannah.gnu.org>
2019-12-27 15:58 ` emacs-27 e1e0a7a 2/2: xref--collect-matches: Speed up on remote Stefan Monnier
2019-12-27 16:18 ` Dmitry Gutov
2019-12-27 19:30 ` Stefan Monnier
2019-12-27 20:19 ` Michael Albinus
2019-12-27 22:06 ` Stefan Monnier [this message]
2019-12-28 10:09 ` Michael Albinus
2019-12-28 16:53 ` Stefan Monnier
2019-12-28 15:22 ` Dmitry Gutov
2019-12-28 16:54 ` Stefan Monnier
2019-12-28 16:58 ` Dmitry Gutov
2019-12-28 18:58 ` Michael Albinus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvmubds9wh.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=dgutov@yandex.ru \
--cc=emacs-devel@gnu.org \
--cc=michael.albinus@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.