From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: Removing no-back-reference restriction from syntax-propertize-rules Date: Sun, 17 May 2020 19:57:24 -0400 Message-ID: References: <87wo5cff39.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="119644"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon May 18 02:07:39 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jaTJj-000V3T-6k for ged-emacs-devel@m.gmane-mx.org; Mon, 18 May 2020 02:07:39 +0200 Original-Received: from localhost ([::1]:42236 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jaTJg-0003Mv-14 for ged-emacs-devel@m.gmane-mx.org; Sun, 17 May 2020 20:07:38 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:45330) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jaT9y-0001pe-UY for emacs-devel@gnu.org; Sun, 17 May 2020 19:57:35 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:45676) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jaT9t-0001f7-2u for emacs-devel@gnu.org; Sun, 17 May 2020 19:57:33 -0400 Original-Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id ED36C10033A; Sun, 17 May 2020 19:57:27 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 321B810025D; Sun, 17 May 2020 19:57:26 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1589759846; bh=pT5AMabqNoTKVx4DVFJFDqsTgmHhMnlBhZl2hqNv8cE=; h=From:To:Subject:References:Date:In-Reply-To:From; b=Ed35Q+/Q42gGzrGEX8Gjm8cExB/CmmWpjkUXcF4Yjbi0JYuPBHezhfKqrq0nFgzrn EZjo+m8JPQpAsM6Z3jQt2MSO4ccsuje0xf0b0vrLH1yFzUmgQdgzW9oUZpc6JQ8HEX 6Mu0pBt6yAFFyB5YUQ0LbrxifsnJgisOtxd0delPyVnHBLNZAGECBzKEX72NL9NkGi 6QG3uGzmpWo9OXAFrxP2Sev2ZNpDvtREKMkJAoAdnlBrX0/g6sBdVdilIKa2nSB1bB s0c1XhT0HyRV/Ch58NZgCZ94ZHjd1ENyd2GikxFNj2gkQRSHJzzD9aTVCtP/pwhDFY RkkHccQ1L/WvA== Original-Received: from alfajor (unknown [216.154.27.250]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id EF4D01207EB; Sun, 17 May 2020 19:57:25 -0400 (EDT) In-Reply-To: <87wo5cff39.fsf@gnu.org> (Tassilo Horn's message of "Sat, 16 May 2020 10:39:54 +0200") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-detected-operating-system: by eggs.gnu.org: First seen = 2020/05/17 19:22:06 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:250687 Archived-At: > -(defun syntax-propertize--shift-groups (re n) > - (replace-regexp-in-string > - "\\\\(\\?\\([0-9]+\\):" > - (lambda (s) > - (replace-match > - (number-to-string (+ n (string-to-number (match-string 1 s)))) > - t t s 1)) > - re t t)) > +(defun syntax-propertize--shift-groups-and-backrefs (re n) > + (let ((incr (lambda (s) > + (replace-match > + (number-to-string > + (+ n (string-to-number (match-string 1 s)))) > + t t s 1)))) > + (replace-regexp-in-string > + "[^\\]\\\\\\([0-9]+\\)" incr > + (replace-regexp-in-string "\\\\(\\?\\([0-9]+\\):" incr re t t) > + t t))) I think it's OK, but I think the risk of false positives for `\N` is sufficiently high (compared to that for `\(?N:`) that I think we need to be more careful and use `subregexp-context-p`. Stefan