From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: master f51f963: Fix some side-effecting uses of make-text-button Date: Thu, 04 Jun 2020 18:44:10 -0400 Message-ID: References: <20200604223056.17078.81265@vcs0.savannah.gnu.org> <20200604223058.1850020A26@vcs0.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="25529"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: "Basil L. Contovounesios" Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Jun 05 00:44:46 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jgybN-0006Wh-9P for ged-emacs-devel@m.gmane-mx.org; Fri, 05 Jun 2020 00:44:45 +0200 Original-Received: from localhost ([::1]:48390 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jgybM-0004lY-C5 for ged-emacs-devel@m.gmane-mx.org; Thu, 04 Jun 2020 18:44:44 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:40882) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jgyau-0004KX-J8 for emacs-devel@gnu.org; Thu, 04 Jun 2020 18:44:16 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:14000) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jgyat-0001jc-5N for emacs-devel@gnu.org; Thu, 04 Jun 2020 18:44:15 -0400 Original-Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 0F26E44144B; Thu, 4 Jun 2020 18:44:14 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 8A32B441449; Thu, 4 Jun 2020 18:44:12 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1591310652; bh=ckpkqIl2GHCVy7cx/ULQCnCJNoDH2s0p+zhKkQZTogA=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=cYlUW06je/e9NUzR4SpaoKSGHU7seBfcC4fePTFfKolLOEw75NPFxsr3GcTNFcZiG gHxNpiQUR6ONQY+5HqxyHJc2CuQQu2q1tfu9nMh3DHULUmMchbzXimBkf7XBex5W0k Qx+V762u2GQU3o2h4PmhEFzbc4DiFkG9JlhyM1/ZtJGUElbeR5NdTnR/avSozmTeAG 6diacKbPqjhOCS+V1EfVm+Gh3kqjolpFtKKZA3rj2qxj22ftN+Un0wcSKSTsnNEoYq UQyasLRN9JwKjXnHNPaENkfvftyxhE7mBHXKY02rm48quc6EL7IVx83YTm9tCYYJq5 VsqarLsjEg5xg== Original-Received: from alfajor (unknown [157.52.17.179]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id C718C1221A8; Thu, 4 Jun 2020 18:44:11 -0400 (EDT) In-Reply-To: <20200604223058.1850020A26@vcs0.savannah.gnu.org> (Basil L. Contovounesios's message of "Thu, 4 Jun 2020 18:30:57 -0400 (EDT)") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-detected-operating-system: by eggs.gnu.org: First seen = 2020/06/04 17:27:39 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:251874 Archived-At: > (make-text-button name nil > 'type 'apropos-library > 'face 'apropos-symbol > - 'apropos-symbol name) > - name))) > + 'apropos-symbol name)))) So, IIUC we consider `make-text-button` to be functional rather than side-effecting, right? > @@ -202,7 +202,7 @@ The format has been repaired and the variable modified accordingly. > You can save the current value through the customize system by > either clicking or hitting return " > (make-text-button > - "here" nil > + (copy-sequence "here") nil > 'face '(:weight bold :inherit button) > 'mouse-face '(:weight normal :background "gray50" :inherit button) > 'follow-link t So, here why do we need to `copy-sequence`? Stefan