From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#46268: 27.1.91; Error in occur-rename-buffer Date: Wed, 03 Feb 2021 10:38:45 -0500 Message-ID: References: <874kitttd3.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="26827"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 46268@debbugs.gnu.org To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Feb 03 16:39:22 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l7KFV-0006s1-0Z for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 03 Feb 2021 16:39:21 +0100 Original-Received: from localhost ([::1]:33976 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l7KFU-0003fY-37 for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 03 Feb 2021 10:39:20 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:41668) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l7KFC-0003fI-Au for bug-gnu-emacs@gnu.org; Wed, 03 Feb 2021 10:39:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:55331) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1l7KFC-0001SD-3G for bug-gnu-emacs@gnu.org; Wed, 03 Feb 2021 10:39:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1l7KFC-00048d-0d for bug-gnu-emacs@gnu.org; Wed, 03 Feb 2021 10:39:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 03 Feb 2021 15:39:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 46268 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 46268-submit@debbugs.gnu.org id=B46268.161236673515887 (code B ref 46268); Wed, 03 Feb 2021 15:39:01 +0000 Original-Received: (at 46268) by debbugs.gnu.org; 3 Feb 2021 15:38:55 +0000 Original-Received: from localhost ([127.0.0.1]:38643 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l7KF5-00048B-Ao for submit@debbugs.gnu.org; Wed, 03 Feb 2021 10:38:55 -0500 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:4800) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l7KF3-00047v-Rb for 46268@debbugs.gnu.org; Wed, 03 Feb 2021 10:38:54 -0500 Original-Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id EE5CF44098C; Wed, 3 Feb 2021 10:38:47 -0500 (EST) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 97E1C440981; Wed, 3 Feb 2021 10:38:46 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1612366726; bh=oTgNAAr6XRIXtHL1DAZhNB8E8G/TZIfDBECB8mAxJcw=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=C37xcjvWhLx31O9yZYKXf3FmMYQKsxvRkBgHf4Iwkep/WuFcxmTP1NwFyDJwto+Ew CkIJ1sb6+uE1K9FJOlU9fYA7L3CmgZXFDk/Qvm+3lFoQ1xOcjVObA2T7j/9Xpo74h9 rnrEUT+m26qXVd3DaUEf+QxxqgH0yG0t/QX+42tOeWucqUMdmj5uzfn4ws0m7t6rdP Xl4Z3UmZOovKRRpzBGQ+48ykQwuTLH+dcznefHjdd/K4PnkF2l++sVPl0NX8jdDLLJ F4Zex/xOJWHLiZwyzez53yANzLjJrVpgZ5B22EqKuuxbUgowMaeiJWSGgoF3bRi1Qi DRRz9KtoEz+0w== Original-Received: from alfajor (76-10-182-85.dsl.teksavvy.com [76.10.182.85]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 66759120377; Wed, 3 Feb 2021 10:38:46 -0500 (EST) In-Reply-To: (Stefan Monnier's message of "Wed, 03 Feb 2021 10:05:43 -0500") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:199207 Archived-At: > AFAICT, `occur--garbage-collect-revert-args` aims to throw away the > overlays when they're not needed, but we will need them again if we want > to `revert-buffer`, so we shouldn't call this function until we're sure > `revert-buffer` won't be called. IOW, I think we should just remove > the above call. I now see what's going on: this call is supposed to throw away the overlay used by the previous invocation of `occur`. So when we revert, we don't want to throw them away but when it's a fresh new invocation, we do. Maybe we should add a (unless (eq bufs (nth 2 occur-revert-arguments)))? Stefan