From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: Caching where-is-internal Date: Mon, 24 May 2021 15:53:27 -0400 Message-ID: References: <87zgwlb4xc.fsf@gmail.com> <87eedxrqz4.fsf@mail.linkov.net> <5213fac0-fcc9-a6aa-0a16-a124d9ec92bc@daniel-mendler.de> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="40890"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Juri Linkov , =?windows-1252?B?Sm/jbyBU4XZvcmE=?= , emacs-devel@gnu.org To: Daniel Mendler Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon May 24 21:54:48 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1llGf1-000ARs-Iw for ged-emacs-devel@m.gmane-mx.org; Mon, 24 May 2021 21:54:47 +0200 Original-Received: from localhost ([::1]:52086 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1llGf0-0002FO-LH for ged-emacs-devel@m.gmane-mx.org; Mon, 24 May 2021 15:54:46 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:57800) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1llGdw-0000si-RY for emacs-devel@gnu.org; Mon, 24 May 2021 15:53:41 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:57348) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1llGdr-0000DV-D9 for emacs-devel@gnu.org; Mon, 24 May 2021 15:53:39 -0400 Original-Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 9724F80169; Mon, 24 May 2021 15:53:33 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 0D8A9803C3; Mon, 24 May 2021 15:53:28 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1621886008; bh=ANvUPt+poFz8iFhWJDYYClLMsmpY5hfuygVU+HOfJtw=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=YVsV+Wh7r5VxPXynOy4mHVMNdO+RRH9BQfl/KOQ5i2DtJ883/KQYpalJCK39D7E6m hamKbdzsgLxB0cvIao8zB/WFoiIfB79red6v1ZI7n3oVHK52mrEx+92wrI+JQ1PHgY GEKUTl6UOekCwB0RldZm8usnHJ0StN8TS+gebKenoiTHuvmM8CNayvdH08eg6yX7xA K/wFykz6/a6vzQO6FE+kCbd05af9zhYTnHPFb+uNHU2ooPsgTYm/SvkxZKkUMYRqSh 2ruFuL0ffjf6g5PzY/fNkY65e8AMVe7L5tet1RGlLveNvbvOGUJQEOff7iOB1BQIXW 9yTwDX9vvGjvQ== Original-Received: from alfajor (69-196-163-239.dsl.teksavvy.com [69.196.163.239]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id C77651209EC; Mon, 24 May 2021 15:53:27 -0400 (EDT) In-Reply-To: <5213fac0-fcc9-a6aa-0a16-a124d9ec92bc@daniel-mendler.de> (Daniel Mendler's message of "Mon, 24 May 2021 18:31:10 +0200") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:269801 Archived-At: > I think the problem was that `where-is-internal` can generate a lot of > garbage memory. In Marginalia we have this code: It would be great if you could track it down further. Maybe it's simply that the cache ends up flushed between invocations (in your use case), defeating its purpose. > (mapatoms > (lambda (sym) > (when-let (key (and (commandp sym) > (where-is-internal sym nil t))) > (puthash sym key marginalia--annotate-binding-hash))))) `where-is-internal` has almost exactly this same hash-table internally, so this basically copies the hash-table (in a somewhat inefficient way). :-( > But I cannot tell you much about the exact reasons. It just turned out > that calling `where-is-internal` once on all symbols was faster than > calling it occasionally. I suspect a "spurious cache flush". Maybe we should export the code that turns a set of keymaps into a (reversed) hash-table. > The funny thing here is that the initial (costly?) computation of the > `marginalia--annotate-binding-hash` does not lead to a noticeable slowdown. The first call to `where-is-internal` will traverse all the keymaps and build the hash-table (which doesn't cost much more than just a plain uncached `where-is-internal`), and the subsequent ones will hit the hash-table instead. Stefan