From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Weird non-caught error in ERT (was: Zero byte-compiler warnings in the test suite) Date: Wed, 22 Dec 2021 19:07:29 -0500 Message-ID: References: <87ilvigl3z.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="8790"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: Lars Ingebrigtsen , emacs-devel@gnu.org, Christian Ohler To: Stefan Kangas Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Dec 23 01:08:20 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1n0Bee-000244-AA for ged-emacs-devel@m.gmane-mx.org; Thu, 23 Dec 2021 01:08:20 +0100 Original-Received: from localhost ([::1]:39676 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1n0Bec-0005mT-Ss for ged-emacs-devel@m.gmane-mx.org; Wed, 22 Dec 2021 19:08:18 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:49714) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n0Bdw-00055x-SS for emacs-devel@gnu.org; Wed, 22 Dec 2021 19:07:36 -0500 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:31033) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n0Bdu-0003Kw-8p; Wed, 22 Dec 2021 19:07:35 -0500 Original-Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id EB3401001C2; Wed, 22 Dec 2021 19:07:31 -0500 (EST) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 7BB7B1000C4; Wed, 22 Dec 2021 19:07:30 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1640218050; bh=rzF7GDnjV8CGp/dwX/RdVOdZIamAhA5/5CtlTmgA+hI=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=W08OkszVuJtT96zlE0dgXBLGktPoTcO+OiDToSAJYbMWWQDtq/O8RoFNwv9VJbYiz B5FOAR1cAdaKieYf7WX0ONf0+NyvWh58ilFiOBbonittRzAyfuoN/cAXv4ZeMCqMRz UKblis2dMoLgS5h3Cejsu3PTX9qS15J6amjgbsP3mjkS/z4QpwTukQpS7uj0WyQVsM beLCeLNDJVzL54gtoup79wTzod3yChLehcxAUXS/muDzFSoGIxllachYe+kj//7ahe aPPTsT5Utqh6L4zyueCWf5FiBPZz8zLOhE7Z0n8h8twCR6fn62ULYGila6xfWxMu7U n3thDzk0LK83A== Original-Received: from pastel (unknown [216.154.30.173]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 354911201D8; Wed, 22 Dec 2021 19:07:30 -0500 (EST) In-Reply-To: (Stefan Kangas's message of "Wed, 22 Dec 2021 14:11:19 -0800") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:282849 Archived-At: >> I'd do something like >> >> (should-error >> (macroexpand-all '(pcase ...))) > > macroexpand-all didn't work, but I installed this, which seems to have > fixed it: Indeed, how odd. I tried: (should (condition-case err (progn (macroexpand-all '(pcase 1 ((cl-type notatype) 'integer))) nil) (error (string-match "Unknown type notabug" (cadr err)))))) and that gives me: Test pcase-tests-cl-type backtrace: error("Unknown type %S" notatype) cl-typep--inliner((cl-typep 1 'notatype) 1 'notatype) apply(cl-typep--inliner (cl-typep 1 'notatype) (1 'notatype)) macroexp--compiler-macro(cl-typep--inliner (cl-typep 1 'notatype)) macroexp--expand-all((pcase--flip cl-typep 'notatype 1)) macroexp--all-forms((if (pcase--flip cl-typep 'notatype 1) (let nil macroexp--expand-all((pcase 1 ((cl-type notatype) 'integer))) macroexpand-all((pcase 1 ((cl-type notatype) 'integer))) (progn (macroexpand-all '(pcase 1 ((cl-type notatype) 'integer))) ni (condition-case err (progn (macroexpand-all '(pcase 1 ((cl-type nota [...] Notice the place where I truncated the stack: we're inside the `condition-case`! So why do we get a backtrace instead of letting `condition-case` catch the error? Stefan