From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: Problem with file-local variables in uni-special-lowercase.el Date: Sat, 01 Jan 2022 17:52:16 -0500 Message-ID: References: <83lezzg7af.fsf@gnu.org> <83fsq7g1hm.fsf@gnu.org> <838rvzfhlg.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="21790"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Jan 01 23:53:16 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1n3nFT-0005QF-73 for ged-emacs-devel@m.gmane-mx.org; Sat, 01 Jan 2022 23:53:15 +0100 Original-Received: from localhost ([::1]:42638 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1n3nFR-0000hy-Eb for ged-emacs-devel@m.gmane-mx.org; Sat, 01 Jan 2022 17:53:13 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:35652) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n3nEe-0008Rd-TD for emacs-devel@gnu.org; Sat, 01 Jan 2022 17:52:25 -0500 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:52230) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n3nEc-0004kT-Df; Sat, 01 Jan 2022 17:52:23 -0500 Original-Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id C31B044143D; Sat, 1 Jan 2022 17:52:19 -0500 (EST) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 57021441431; Sat, 1 Jan 2022 17:52:18 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1641077538; bh=B1U0ANpDqb5a/LPv4GECHDm44WkzdwP2BPmmsRcqrt4=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=F7xmN6T5WOQQ2hI/y2Q4gpqyKTXQzppJwlm4+DrG+aBzJVyoW7FWEP0K+uUzcHRcZ bBbWnNbSY9Knv5hwYq3vK29VQ4YR4TgBp4wAvO7xtoLU/g8ISodTRJ1ARzf/PTJCtW coJmXblKHsc0cbwnqJcAiZctGKELCxxusjtBdgSxzKq8oErJLhLa46M+x2CJvspmnD rVaopEy1JJj6wXrPjZC1GchBWi1ULZH2/RFrd67OxsKcan1aaLujcB6DLxbKjj0NDK Fu5o5qE+vnT8yR9r97RqWr+JanvCNTdFCiG41tlKIlrgnhyErakulWHm0Yyjl5WvQN 4NR1tjNwVccYQ== Original-Received: from ceviche (unknown [216.154.30.173]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 2B32E120201; Sat, 1 Jan 2022 17:52:18 -0500 (EST) In-Reply-To: <838rvzfhlg.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 01 Jan 2022 20:15:07 +0200") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -23 X-Spam_score: -2.4 X-Spam_bar: -- X-Spam_report: (-2.4 / 5.0 requ) DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:283828 Archived-At: >> >> There's some strange problem with this file: when building Emacs after >> >> it is updated, byte-compilation of various Lisp files fails with error >> >> message like this: >> > >> > FWIW, it seems to start happening as soon as charprop.el is >> > regenerated, whenever the new charprop.el is reloaded by the >> > byte-compilation process. [ Apparently `uni-special-lowercase.el` and its friends are preloaded in the dump (even though they don't appear in `loadup.el`). ] I suspect this problem is newly introduced by the symbol-shorthands code, which apparently uses just enough more of the `hack-local-variables` machinery to trigger it. The patch below seems to circumvent the problem. Stefan diff --git a/lisp/international/mule-cmds.el b/lisp/international/mule-cmds.el index de1331e12a9..8b61a88f136 100644 --- a/lisp/international/mule-cmds.el +++ b/lisp/international/mule-cmds.el @@ -2958,8 +2958,14 @@ define-char-code-property (or (stringp table) (error "Not a char-table nor a file name: %s" table))) (if (stringp table) (setq table (purecopy table))) - (setf (alist-get name char-code-property-alist) table) - (put name 'char-code-property-documentation (purecopy docstring))) + (if (and (stringp table) + (char-table-p (alist-get name char-code-property-alist))) + ;; The table is already setup and we're apparently trying to + ;; undo that, probably because `charprop.el' is being re-loaded. + ;; Just skip it. + nil + (setf (alist-get name char-code-property-alist) table) + (put name 'char-code-property-documentation (purecopy docstring)))) (defvar char-code-property-table (make-char-table 'char-code-property-table)