From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: git tip: Error in winner-save-old-configurations (flyspell-post-command-hook): (wrong-type-argument stringp nil) [73 times] Date: Wed, 07 Sep 2022 14:00:04 -0400 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="37207"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Sep 07 20:02:42 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oVzNo-0009Xi-W0 for ged-emacs-devel@m.gmane-mx.org; Wed, 07 Sep 2022 20:02:41 +0200 Original-Received: from localhost ([::1]:49462 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oVzNl-0001tX-SX for ged-emacs-devel@m.gmane-mx.org; Wed, 07 Sep 2022 14:02:39 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:34990) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oVzLO-0000Ew-Oz for emacs-devel@gnu.org; Wed, 07 Sep 2022 14:00:10 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:3102) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oVzLM-000891-39 for emacs-devel@gnu.org; Wed, 07 Sep 2022 14:00:09 -0400 Original-Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 5B9A444137E; Wed, 7 Sep 2022 14:00:06 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 0FD0C44100D; Wed, 7 Sep 2022 14:00:05 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1662573605; bh=LPIcMY8IPgDt4Ny0Mykw30tXn4VlfipWhoKNWZGPR+k=; h=From:To:Subject:In-Reply-To:References:Date:From; b=W1KZE1ukdcQOH6SVR/4ZsmNaE/u1aiyEh1pJV5wTw4aePyOP/TM6lsp0sz6ug34OI 33rWOmhaY7lFU/Vcc27WgJ8mIEE/fm3vKy8xF/SnEe2D+GruIUxvflL/B3dSDBUec3 ga+CnLEDtZ2IYSZBjn4w5r1N55heaQGY3kcnw0fPfRFZUw0rq8lkcA0LJToidqfdcx NBq6xjS2aZfcDgj5WgwGN3+bG8wpg8NNlhJgN04Hd2BAoZqjHIyH2wN9eWaNxwGFYo od+OG/dX9uMtSkQhn5AEqITG9TTew66euWM7ep4tx00t/NZb9cpPtBPhVYuN5WlU4Z i7urOdwp6xbZQ== Original-Received: from lechazo (lechon.iro.umontreal.ca [132.204.27.242]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 0400B120748; Wed, 7 Sep 2022 14:00:05 -0400 (EDT) In-Reply-To: (Sam Steingold's message of "Tue, 06 Sep 2022 15:47:23 -0400") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:294859 Archived-At: Sam Steingold [2022-09-06 15:47:23] wrote: > Error in winner-save-old-configurations (flyspell-post-command-hook): > (wrong-type-argument stringp nil) Hmm... actually, this is a good clue: in this error message the part after "in" should be the hook's name. So I suspect the problem comes from my commit 5cae71834bd55e0bf90689b12b801206ee8c9da9. More specifically, I suspect that the (hideous) patch below might fix your problem. Could you confirm (so I can find a better fix)? Stefan diff --git a/src/keyboard.c b/src/keyboard.c index 77280d08c5b..6b4253b7256 100644 --- a/src/keyboard.c +++ b/src/keyboard.c @@ -1887,6 +1887,7 @@ safe_run_hook_funcall (ptrdiff_t nargs, Lisp_Object *args) args[0] = hook, args[1] = fun; internal_condition_case_n (safe_run_hooks_1, nargs, args, Qt, safe_run_hooks_error); + args[0] = fun, args[1] = hook; return Qnil; }