From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: Progress for bug#59314 for emacs-29 Date: Wed, 21 Dec 2022 00:19:41 -0500 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="11329"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: emacs-devel@gnu.org, Alexander Adolf To: Thomas Fitzsimmons Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Dec 21 06:20:27 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p7rWX-0002DK-UJ for ged-emacs-devel@m.gmane-mx.org; Wed, 21 Dec 2022 06:20:14 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p7rW9-00066o-12; Wed, 21 Dec 2022 00:19:49 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p7rW7-00066g-EA for emacs-devel@gnu.org; Wed, 21 Dec 2022 00:19:47 -0500 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p7rW6-0006Mz-1i for emacs-devel@gnu.org; Wed, 21 Dec 2022 00:19:47 -0500 Original-Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 8C98F4400EF; Wed, 21 Dec 2022 00:19:44 -0500 (EST) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 3DFB044009B; Wed, 21 Dec 2022 00:19:43 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1671599983; bh=Iexjcgfvl46g2OzW4cgRGyOd0BT7FZ2Rn4cuDNFTmF0=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=Tfi78bfpr7Vf+TDPXR32j9bHmg7jVxWd7o0Irwi0gEV7gxP4reLwwYmXOMsucS6xf d98VUIeGX660Uvzp04thMFPfsRLXKyKJeNIIpbgoSmw1IbtF+b/f9fODhQPBFd9kP2 2qI0zYtQwzQjUn8d1dK/tVJ0TbWIpL+9mL8VCgyVahfWsuzAywPosSXQD3PJLaQvxu sFBQn1XQkuxcNBXbSwwwrSjwJxqxUXb94AUDwydLwq9E0LQy7LKFIxEa3HryXyzGT9 0zVrJRlzOoWbRXIpc7bNFz0Lovk5E8xXgaP6Dndmcs7WfKgiGWvzyx13N4xRS0xGRB hoX0tzvQYHg9w== Original-Received: from pastel (unknown [45.72.200.228]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 14D1212306C; Wed, 21 Dec 2022 00:19:43 -0500 (EST) In-Reply-To: (Thomas Fitzsimmons's message of "Tue, 20 Dec 2022 21:59:41 -0500") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:301728 Archived-At: > + (when (and (or eudc-server eudc-server-hotlist) > + (seq-some #'derived-mode-p eudc-capf-modes) > + (let ((mail-abbrev-mode-regexp message-email-recipient-header-regexp)) > + (mail-abbrev-in-expansion-header-p))) > + (setq-local completion-styles '(substring partial-completion)) > + (eudc-capf--message-expand-name))) Please don't do that. `completion-styles` is a user-config, we shouldn't mess with it. Instead you should use `completion-category-defaults` (and use a completion table which returns an appropriately chosen `category`). Then users can decide to override your choice with `completion-category-overrides`. Stefan