all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Thomas Fitzsimmons <fitzsim@fitzsim.org>
Cc: emacs-devel@gnu.org,
	Alexander Adolf <alexander.adolf@condition-alpha.com>
Subject: Re: Progress for bug#59314 for emacs-29
Date: Wed, 21 Dec 2022 00:19:41 -0500	[thread overview]
Message-ID: <jwvmt7hnxp9.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <m3fsd9ihr6.fsf@fitzsim.org> (Thomas Fitzsimmons's message of "Tue, 20 Dec 2022 21:59:41 -0500")

> +  (when (and (or eudc-server eudc-server-hotlist)
> +             (seq-some #'derived-mode-p eudc-capf-modes)
> +             (let ((mail-abbrev-mode-regexp message-email-recipient-header-regexp))
> +               (mail-abbrev-in-expansion-header-p)))
> +    (setq-local completion-styles '(substring partial-completion))
> +    (eudc-capf--message-expand-name)))

Please don't do that.  `completion-styles` is a user-config, we
shouldn't mess with it.  Instead you should use
`completion-category-defaults` (and use a completion table which returns
an appropriately chosen `category`).  Then users can decide to override
your choice with `completion-category-overrides`.


        Stefan




  reply	other threads:[~2022-12-21  5:19 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-21  2:59 Progress for bug#59314 for emacs-29 Thomas Fitzsimmons
2022-12-21  5:19 ` Stefan Monnier [this message]
2022-12-23 14:59   ` Alexander Adolf
2022-12-21 12:14 ` Eli Zaretskii
2022-12-21 12:54   ` Thomas Fitzsimmons
2022-12-21 13:46     ` Eli Zaretskii
2022-12-22 11:59       ` Alexander Adolf
2022-12-22 11:56 ` Alexander Adolf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwvmt7hnxp9.fsf-monnier+emacs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=alexander.adolf@condition-alpha.com \
    --cc=emacs-devel@gnu.org \
    --cc=fitzsim@fitzsim.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.