From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: master f866c85ac4e: (jsonrpc--log-event): Try and fix bug#68072 Date: Sun, 07 Jan 2024 10:02:06 -0500 Message-ID: References: <170460373801.27011.3995281640682361109@vcs2.savannah.gnu.org> <20240107050218.48567C002E0@vcs2.savannah.gnu.org> <87jzol77iw.fsf@yahoo.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="32735"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: emacs-devel@gnu.org To: Po Lu Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Jan 07 16:02:49 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rMUfn-0008Ii-2x for ged-emacs-devel@m.gmane-mx.org; Sun, 07 Jan 2024 16:02:48 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rMUfF-0002TN-CO; Sun, 07 Jan 2024 10:02:13 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rMUfC-0002Sv-NH for emacs-devel@gnu.org; Sun, 07 Jan 2024 10:02:10 -0500 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rMUfB-0007XC-7y for emacs-devel@gnu.org; Sun, 07 Jan 2024 10:02:10 -0500 Original-Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 6B73B10009E; Sun, 7 Jan 2024 10:02:08 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1704639727; bh=rZXCoNu8rVWA0pK9++l3+qamjce7EHA+m5rkeS3xwU0=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=hZCvtNIS2KnPWG6HhSLBsklZI+q7+uCorL2S6g//N3MpjoJkjhAr1DXcfhj/dpVPf 7iuD99flndhKXWPghhp/ynjwTX5YlTva1q7ftfqKPqeAPAkxOS6mYMwJShocT3FOC6 D/qfDBlJCzTrp2pI8Tl79QFVj47qnwVE1P+sXErabEuaQqQ1lxjinrPwN/RIaveqgN q5Rn65CgqXfLwmFA1FA637ZBWQaXzF3COzS65sljekKEW/YPJWyHBtr31vNqe6CHNz RI1ibzR9t+lf10/7+ZbBE+cLrm3KgnUjrmT9lR+SPraM82GvCelArxlxjS5ndOWPPp HaAdIeRbLBTag== Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 8674F100068; Sun, 7 Jan 2024 10:02:07 -0500 (EST) Original-Received: from pastel (65-110-221-238.cpe.pppoe.ca [65.110.221.238]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 62E9B120B54; Sun, 7 Jan 2024 10:02:07 -0500 (EST) In-Reply-To: <87jzol77iw.fsf@yahoo.com> (Po Lu's message of "Sun, 07 Jan 2024 18:38:31 +0800") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:314688 Archived-At: > Is there any substantive reason it was necessary to replace cond with > pcase? If not, why was cond replaced with pcase? The reason why the `cond` expression was touched was to reduce indentation in order to stay within 80 columns. The reason why this "touching" ended up changing the cond to a case is because of personal style preferences. Stefan