From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: Okamsn <okamsn@protonmail.com>,
68863@debbugs.gnu.org, Nicolas Petton <nicolas@petton.fr>
Subject: bug#68863: Add support for using setf with seq-subseq
Date: Thu, 08 Feb 2024 09:25:51 -0500 [thread overview]
Message-ID: <jwvmssbqbmx.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <86y1bvw5ff.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 08 Feb 2024 13:39:48 +0200")
>> This patch adds support for using `seq-subseq` with `setf`, as in
>>
>> ;; => [0 1 2 10 11]
>> (let ((seq (vector 0 1 2 3 4)))
>> (setf (seq-subseq seq -2) (list 10 11 12 13 14))
>> seq)
>>
>> The patch adds a generic version which uses the existing `setf` support
>> of `seq-elt` and a specialized version for modifying lists. Both
>> versions use `seq-do` to map a function over the values that should
>> replace the values in the modified sequence.
> Nicolas, Stefan: any comments?
Fine by me.
>> To avoid modifying more values than specified, that modifying function
>> uses a `when` condition. I'm not sure of a good way to stop `seq-do`
>> early when we know that it can stop calling the modifying function.
>> Normally, I would use `cl-block` and `cl-return`. Is it OK to use those
>> features in `seq.el`? If not, is it worth adding something like a
>> `seq-map-while` or a `seq-do-while`?
`seq.el` is used by some parts of the implementation of `cl-lib`, so
the use of `cl-lib` risks introducing a circular dependency. Maybe using
`cl-block/return` would be OK, but I wouldn't be surprised if it causes
bootstrap trouble. You can use catch/throw, OTOH.
Stefan
next prev parent reply other threads:[~2024-02-08 14:25 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-01 3:31 bug#68863: Add support for using setf with seq-subseq Okamsn via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-02-04 18:33 ` bug#68863: [PATCH] " Okamsn via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-02-08 11:39 ` bug#68863: " Eli Zaretskii
2024-02-08 14:25 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
2024-02-09 3:54 ` Okamsn via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-02-14 2:50 ` Okamsn via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-04-18 2:54 ` Okamsn via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-05-07 1:45 ` Okamsn via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-05-08 21:01 ` Michael Heerdegen via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-05-09 12:16 ` Michael Heerdegen via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-05-09 13:55 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-05-14 12:47 ` Okamsn via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-05-14 15:52 ` Michael Heerdegen via Bug reports for GNU Emacs, the Swiss army knife of text editors
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvmssbqbmx.fsf-monnier+emacs@gnu.org \
--to=bug-gnu-emacs@gnu.org \
--cc=68863@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=monnier@iro.umontreal.ca \
--cc=nicolas@petton.fr \
--cc=okamsn@protonmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.