From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: feature/type-hierarchy 8a63e50036f 1/5: * Define 'cl--type-hierarchy' and compute 'cl--typeof-types' from it Date: Sun, 03 Mar 2024 12:31:22 -0500 Message-ID: References: <170801660982.26727.13226947668211497607@vcs2.savannah.gnu.org> <20240215170330.82819C0F009@vcs2.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="13539"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: emacs-devel@gnu.org To: Andrea Corallo Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Mar 03 18:32:18 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rgphB-0003Ik-Nm for ged-emacs-devel@m.gmane-mx.org; Sun, 03 Mar 2024 18:32:17 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rgpgT-0005Af-R8; Sun, 03 Mar 2024 12:31:33 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rgpgN-0005A2-TL for emacs-devel@gnu.org; Sun, 03 Mar 2024 12:31:31 -0500 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rgpgM-00022s-EC; Sun, 03 Mar 2024 12:31:27 -0500 Original-Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 6F92580B20; Sun, 3 Mar 2024 12:31:24 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1709487083; bh=Ixom55zdZaAoqt2EAF9S0bcRNbkA2SXq1J8DzR28Gws=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=I4ZgD2suGTEpooNykJ7Ln4BljbySx6vjW6PocUMFBNoX6e18ZDAIcEG3QJFVpNSCr E8EeJJ6kRNJuesXrUcQ3tu4cWt4avO+auprrX7whjB7S3gUqyeufJZTasvpmZE7HYn QqIHFcCu9UUNcDP5pLyO0CSpuq7K6tCRmi/eS1EAvBrQybcRsLhXO22Hd+RfQ9D0SD iuOPxToROjr4ekdwMUiaROkqyF0gt3wmOLSLVfzE7aNkV/KweI0YOeTHmsh0CN4oUG M3Xf7uczAv7WXVy8RIyUJdgvDpK1pLEog50nKLfbSziDLepYzH6I0rEDfztc+3x+Ck /AZqeC6MfQiLg== Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 7105D806A3; Sun, 3 Mar 2024 12:31:23 -0500 (EST) Original-Received: from pastel (unknown [104.247.233.29]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 4821C1201DA; Sun, 3 Mar 2024 12:31:23 -0500 (EST) In-Reply-To: (Andrea Corallo's message of "Sun, 03 Mar 2024 11:56:07 -0500") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:316762 Archived-At: > Looks to me better now, this is the content on my Emacs after having > pushed 8d11b7e4275, please have a look: looks OK, thanks (modulo structure/class because I don't know what these mean). > Also is not clear to me if 'cl--typeof-types' should include all types > or only leaf ones. The intention was to include only leaf types, i.e. the types that `type-of` can return, since the main purpose was to find the (ordered) list of parents in: (cl-generic-define-generalizer cl--generic-typeof-generalizer ;; FIXME: We could also change `type-of' to return `null' for nil. 10 (lambda (name &rest _) `(if ,name (type-of ,name) 'null)) (lambda (tag &rest _) (and (symbolp tag) (assq tag cl--typeof-types)))) > The original was inconsistent on this, Maybe that was an oversight. Do you remember which inconsistency you had noticed in this respect? > this version evidently includes all types but should be easy to > generate only based on the leaf ones if necessary. Having extra types doesn't bring any benefit that I can see but is fairly harmless (it may just slow down ever so slightly a few method dispatches, when we have a miss in the method cache). Stefan