Re: smtpmail.el and 1msg

[Stefan Monnier <monnier@iro.umontreal.ca>]

>> While I think it's good to add support for 1msg, I also think it would be
>> worthwhile to fix the spinning problem.  After all, if the other end closes
>> the connection, we should detect it.  Do we?  If `no' why not and if `yes'
>> why does it spin?

> Detecting closed connections, during the spin loop, was the intention
> of my patch.  They weren't detected before. What do you think?

Yes, I've now seen your patch, looks fine.

> 	(while (not (search-forward "\r\n" nil t))
> 	  (unless (memq (process-status process) '(open run))
> 	    (throw 'done nil))
> 	  (accept-process-output process)
> 	  (goto-char smtpmail-read-point))

Isn't it possible to just check the return value of accept-process-output?
Something like

   (while (not (search-forward "\r\n" nil t)
     (unless (accept-process-output process)
       (throw 'done nil))
     (goto-char smtpmail-read-point))


-- Stefan