all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Glenn Morris <rgm@gnu.org>
Cc: emacs-devel@gnu.org
Subject: Re: make defcustom automatically mark some variables as safe
Date: Thu, 25 Oct 2007 21:18:14 -0400	[thread overview]
Message-ID: <jwvlk9qr83m.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <be1wbjomx4.fsf@fencepost.gnu.org> (Glenn Morris's message of "Thu\, 25 Oct 2007 00\:09\:27 -0400")

> What do people think of the idea of changing defcustom to give
> some variable types a safe-local-variable property by default?

> I mean that, eg, defcustom'ing a variable of :type integer would do:
> (put 'variable 'safe-local-variable 'integerp)

> Similarly for :type boolean (booleanp), string and regexp (stringp),
> and others where it makes sense.

I think this is wrong: one of the main changes in Emacs-22 w.r.t file-local
variables is that we made them safe: from no on, a file-local variable
should never be blindly accepted if we're not "sure" that it's safe.

So this would be a step backward since it would usually make good decisions
but not always (e.g. `enable-local-eval' could very well have been defined
with `:type boolean') so that would introduce security holes until someone
notices them.


        Stefan

  reply	other threads:[~2007-10-26  1:18 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-10-25  4:09 make defcustom automatically mark some variables as safe Glenn Morris
2007-10-26  1:18 ` Stefan Monnier [this message]
2007-10-26  2:50   ` Glenn Morris
2007-10-26  3:49 ` Richard Stallman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwvlk9qr83m.fsf-monnier+emacs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=emacs-devel@gnu.org \
    --cc=rgm@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.