From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: Fwd: Patch for sgml-mode.el Date: Fri, 30 Nov 2007 22:16:20 -0500 Message-ID: References: <0o4pfcvird.fsf@fencepost.gnu.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1196479005 28184 80.91.229.12 (1 Dec 2007 03:16:45 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 1 Dec 2007 03:16:45 +0000 (UTC) Cc: Martin Pohlack , rms@gnu.org, emacs-devel@gnu.org To: Glenn Morris Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Dec 01 04:16:52 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1IyIqa-0003Hl-CG for ged-emacs-devel@m.gmane.org; Sat, 01 Dec 2007 04:16:52 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IyIqK-00043A-3X for ged-emacs-devel@m.gmane.org; Fri, 30 Nov 2007 22:16:36 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1IyIqG-00042F-1j for emacs-devel@gnu.org; Fri, 30 Nov 2007 22:16:32 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1IyIqE-000420-4N for emacs-devel@gnu.org; Fri, 30 Nov 2007 22:16:31 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IyIqD-00041x-UW for emacs-devel@gnu.org; Fri, 30 Nov 2007 22:16:29 -0500 Original-Received: from tomts13.bellnexxia.net ([209.226.175.34] helo=tomts13-srv.bellnexxia.net) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1IyIq6-0008QL-2A; Fri, 30 Nov 2007 22:16:22 -0500 Original-Received: from toip4.srvr.bell.ca ([209.226.175.87]) by tomts13-srv.bellnexxia.net (InterMail vM.5.01.06.13 201-253-122-130-113-20050324) with ESMTP id <20071201031621.SCLI13659.tomts13-srv.bellnexxia.net@toip4.srvr.bell.ca>; Fri, 30 Nov 2007 22:16:21 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Ah4FAPtgUEdGN4zh/2dsb2JhbACBWw Original-Received: from bas1-montreal42-1178045665.dsl.bell.ca (HELO pastel.home) ([70.55.140.225]) by toip4.srvr.bell.ca with ESMTP; 30 Nov 2007 22:18:51 -0500 Original-Received: by pastel.home (Postfix, from userid 20848) id CC4CD7F61; Fri, 30 Nov 2007 22:16:20 -0500 (EST) In-Reply-To: (Glenn Morris's message of "Fri, 30 Nov 2007 15:58:17 -0500") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.50 (gnu/linux) X-detected-kernel: by monty-python.gnu.org: Solaris 8 (1) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:84403 Archived-At: >> Does the patch below fix those problems? > Well, it probably does, but does the incompatible change of allowing > mode-name to be a non-string bring any benefits? The obvious one: no need to manually recompute the string when one of its constituents changes. I.e. sgml-xml-mode does not need to know that enabling/disabling it can change the mode-name from/to SGML/XML or HTML/XHTML. Cleaner code, more obviously correct. If you look at what Ibuffer does with its mode-name, you'll see that it might also benefit from using this feature (tho I guess using mode-line-process could be better so that the annotations don't show up in the buffer's mode name in buffer lists). Stefan