From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: doc-view support for bookmark.el Date: Tue, 25 Dec 2007 18:07:32 -0500 Message-ID: References: <8763yn3v07.fsf@member.fsf.org> <87prwu3kg0.fsf@member.fsf.org> <87prwu77ug.fsf@member.fsf.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1198624068 29350 80.91.229.12 (25 Dec 2007 23:07:48 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 25 Dec 2007 23:07:48 +0000 (UTC) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Dec 26 00:08:01 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1J7IsR-0006wX-Md for ged-emacs-devel@m.gmane.org; Wed, 26 Dec 2007 00:07:59 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1J7Is7-0000Gb-2Q for ged-emacs-devel@m.gmane.org; Tue, 25 Dec 2007 18:07:39 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1J7Is3-0000D2-Ai for emacs-devel@gnu.org; Tue, 25 Dec 2007 18:07:35 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1J7Is2-0000CC-OS for emacs-devel@gnu.org; Tue, 25 Dec 2007 18:07:35 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1J7Is2-0000By-Hq for emacs-devel@gnu.org; Tue, 25 Dec 2007 18:07:34 -0500 Original-Received: from zue-tix-bbcs-dynip-165-113.vtx.ch ([83.228.165.113] helo=ceviche.home) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1J7Is2-00076t-4x for emacs-devel@gnu.org; Tue, 25 Dec 2007 18:07:34 -0500 Original-Received: by ceviche.home (Postfix, from userid 20848) id EF10BB40DB; Tue, 25 Dec 2007 18:07:32 -0500 (EST) In-Reply-To: <87prwu77ug.fsf@member.fsf.org> (Tassilo Horn's message of "Tue, 25 Dec 2007 23:00:39 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.50 (gnu/linux) X-detected-kernel: by monty-python.gnu.org: Linux 2.6 (newer, 3) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:85462 Archived-At: > + (if handler > + (funcall handler bookmark) > + (bookmark-jump-noselect bookmark)))) Aka (funcall (or handler 'bookmark-jump-noselect) bookmark) > Do you think it's ok and I should install it? Looks good from a cursory glance at it, although the repetition of all those bookmark-get-handler + if + funcall is begging for some redundancy-reduction. Stefan